Skip to content

[SF][A11y][ui5-shellbar] Shellbar menu button accessibility #6826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 task done
ee92 opened this issue Mar 29, 2023 · 2 comments · May be fixed by #11238
Open
1 task done

[SF][A11y][ui5-shellbar] Shellbar menu button accessibility #6826

ee92 opened this issue Mar 29, 2023 · 2 comments · May be fixed by #11238
Assignees
@dobrinyonkov
Labels
ACC feature request Medium Prio SAP SF TOPIC P ui5-shellbar

Comments

@ee92
Copy link

ee92 commented Mar 29, 2023

Bug Description

The shellbar menu button is read by screenreaders as <primary-title>, menu pop up collapsed, button

For SuccessFactors the menu button uses the page title as the primary-title and it can be confusing the the screenreader users because the button has the same purpose but is read differently on different pages.

Affected Component

ui5-shellbar

Expected Behaviour

Our accessibility expert suggests the menu button be labelled by something like Navigation, menu pop up collapsed, <primary-title> currently selected

It may not be the ideal label for every use case, so an additional property can be provided to set the aria-label of the menu button, like menu-button-label

Isolated Example

https://sap.github.io/ui5-webcomponents/playground/components/ShellBar/

Steps to Reproduce

  1. Using a screenreader tab to the menu button
  2. Notice it reads "Corporate Portal, menu pop up collapsed, button"

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

1.11.0

Browser

Chrome

Operating System

No response

Additional Context

SuccessFactors accessibility

Declaration

  • I’m not disclosing any internal or sensitive information.
@ee92 ee92 added the bug This issue is a bug in the code label Mar 29, 2023
@unazko unazko self-assigned this Mar 30, 2023
@unazko
Copy link
Contributor

unazko commented Mar 30, 2023

Hello "@SAP/ui5-webcomponents-topic-p,

The ui5-button announcement in the sample with JAWS 2023 is as follows:
"Corporate Portal, button, menu".

Not sure what should be the proper announcement in this case and if aria-labelledby or aria-describedby references could be added via accessibleName/accessibleNameRef APIs, in order to improve the announcements at application side.

Could you please have a look.

Best regards,
Boyan

@unazko unazko removed their assignment Mar 30, 2023
@dobrinyonkov dobrinyonkov added feature request and removed bug This issue is a bug in the code labels Apr 6, 2023
@dobrinyonkov dobrinyonkov self-assigned this May 4, 2023
@JarrettChan JarrettChan mentioned this issue Apr 9, 2024
Open
1 task
@dobrinyonkov
Copy link
Contributor

Internal Reference: BGSOFUIPIRIN-6791

@dobrinyonkov dobrinyonkov moved this from New to Approved in Planning - Topic P Mar 14, 2025
kgogov added a commit that referenced this issue Apr 15, 2025
@kgogov
feat(ui5-shellbar): add branding area accessibility attributes
7d606d2 
Enhance accessibility for the ShellBar component by adding support for custom
accessibility attributes on the branding/primary title area. This allows
developers to provide consistent screen reader announcements for menu buttons
across different pages, regardless of the changing page title content.

Fixes: #6826, #8708
@kgogov kgogov linked a pull request Apr 15, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dobrinyonkov dobrinyonkov

Labels
ACC feature request Medium Prio SAP SF TOPIC P ui5-shellbar
Projects
Planning - Topic P
Status: Approved
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ui5-shellbar): add branding area accessibility attributes SAP/ui5-webcomponents
4 participants
@ilhan007 @unazko @dobrinyonkov @ee92