Skip to content

[Feature Request]: ui5-shellbar profile button aria-label #8708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
JarrettChan opened this issue Apr 9, 2024 · 3 comments
Open
1 task done

[Feature Request]: ui5-shellbar profile button aria-label #8708

JarrettChan opened this issue Apr 9, 2024 · 3 comments

Comments

@JarrettChan
Copy link

JarrettChan commented Apr 9, 2024

Feature Request Description

Provide an API for setting aria-label of the ui5-shellbar profile button.

Similar to this request for the ui5-shellbar menu button #6826

Proposed Solution

Add support for accessibilityNames.profileButtonName to set the profile button aria-label

Proposed Alternatives

No response

Organization

SuccessFactors

Additional Context

We have an incident where the screenreader's button finder used the aria-label of the Avatar component inside of the profile button as "Avatar, collapsed subMenu".
accessibleName in Avatar can not override the aria-label with a falsey value.

Priority

Low

Privacy Policy

  • I’m not disclosing any internal or sensitive information.
@niyap
Copy link
Contributor

niyap commented Apr 10, 2024

Hello @SAP/ui5-webcomponents-topic-p,

Could you please take a look of this feature request?

Thank you in advance!

Kind Regards,
Niya

@JarrettChan
Copy link
Author

As a workaround I will set the accessible-name of my [ui5-avatar][slot="profile"] component.

@dobrinyonkov
Copy link
Contributor

Internal reference: BGSOFUIPIRIN-6547

@petyabegovska petyabegovska moved this to Approved in Planning - Topic P Jun 21, 2024
kgogov added a commit that referenced this issue Apr 15, 2025
Enhance accessibility for the ShellBar component by adding support for custom
accessibility attributes on the branding/primary title area. This allows
developers to provide consistent screen reader announcements for menu buttons
across different pages, regardless of the changing page title content.

Fixes: #6826, #8708
kgogov added a commit that referenced this issue Apr 16, 2025
Enhance accessibility for the ShellBar component by adding support for custom
accessibility attributes on the branding/primary title area. This allows
developers to provide consistent screen reader announcements for menu buttons
across different pages, regardless of the changing page title content.

Fixes: #6826, #8708
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Approved
Development

No branches or pull requests

6 participants