merge vyper locators natively in uiveri5 #175
Conversation
| "data-sap-ui": "*categoryList-0", | ||
| "role": "option", | ||
| "class": "*sapMLIB*sapMSLI", | ||
| "id": "__item1-container-cart---homeView--categoryList-0" |
There was a problem hiding this comment.
please avoid examples with unstable ids
There was a problem hiding this comment.
its intented this way but will be adjusted anyway
| }); | ||
|
|
||
| it("step0v1: check name is Accessories - check with dom properties nodename and id", async function () { | ||
| await browser.sleep(5000); |
There was a problem hiding this comment.
are all these sleeps necessary? is there something wrong with the synchronization?
There was a problem hiding this comment.
no not necessary again intented
| */ | ||
| VyperLocator.prototype.register = function (by) { | ||
| this.logger.debug('Registering custom locator'); | ||
| by.ui5All = function(mMatchers) { |
There was a problem hiding this comment.
all to me sounds like 'element.all' and is confusing
There was a problem hiding this comment.
this is the way that is writen currently, it will not change yet but improvement will be considered (unfortunetaly was called like that always before we got it handover to us)
| if(mParams.prevSiblingProperties || | ||
| mParams.nextSiblingProperties || | ||
| mParams.siblingProperties) { | ||
| // ? |
There was a problem hiding this comment.
until we have a matcher/selector for this, log a message saying this isn't supported and will be ignored?
There was a problem hiding this comment.
will do, I want to write everything down and send an email with all the consolidate points
| var elem = await common.locator.getDisplayedElement(ui5ControlProperties); | ||
| var attribute = "tooltip"; | ||
| var compareValue ="Open category Accessories"; | ||
| var val = await ui5ControlConverter.getControlAggregationProperty(elem, attribute); |
There was a problem hiding this comment.
we have a getProperty method in uiveri5/control.js, perhaps we should just extend it with getters for aggregations and bindings?
There was a problem hiding this comment.
yes thats another point that in my list
| "text":[{"path": "i18n>welcomeCarouselShipping"}] | ||
| }} | ||
| }; | ||
| await ui5.common.assertion.expectAttributeToBe(ui5ControlProperties, "showHeader", "true", 0, 1, 30000); |
There was a problem hiding this comment.
note: we can declare the custom matchers in conf.js
There was a problem hiding this comment.
what do you mean custom matcher?
|
hi @tsaleksandrova : Thanks for the review, but its not intented on review this yet, have to adjust things first |
|
|
No description provided.