Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Do not use the linting-tsconfig for emitting files #54

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

RandomByte
Copy link
Member

Only use "tsconfig.build.json" for building and emitting. Use
"tsconfig.json" for checking for compiler errors and for integrating
with typescript-eslint.

The directory structure emitted when using "tsconfig.json" is different
from the regular build in the sense that it contains an additional "src"
directory level.

Configuring "noEmit: true" in the tsconfig file causes issues for the
typescript-eslint integration. Therefore the flag is only set in the npm
script.

Only use "tsconfig.build.json" for building and emitting. Use
"tsconfig.json" for checking for compiler errors and for integrating
with typescript-eslint.

The directory structure emitted when using "tsconfig.json" is different
from the regular build in the sense that it contains an additional "src"
directory level.

Configuring "noEmit: true" in the tsconfig file causes issues for the
typescript-eslint integration. Therefore the flag is only set in the npm
script.
@RandomByte RandomByte requested a review from a team March 26, 2024 14:16
@RandomByte RandomByte merged commit 84566be into main Mar 26, 2024
18 checks passed
@RandomByte RandomByte deleted the linting-tsconfig-fix branch March 26, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants