Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Detect non-Test Starter test setups #448

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: Detect non-Test Starter test setups #448

wants to merge 8 commits into from

Conversation

d3xter666
Copy link
Contributor

JIRA: CPOUI5FOUNDATION-894

@d3xter666 d3xter666 marked this pull request as draft December 16, 2024 13:49
@d3xter666 d3xter666 force-pushed the feat-detect-teststarter branch from 0bdef16 to fbdd934 Compare December 19, 2024 13:44
@d3xter666 d3xter666 marked this pull request as ready for review December 19, 2024 13:44
@d3xter666 d3xter666 requested review from a team and KlattG December 19, 2024 13:44
@d3xter666
Copy link
Contributor Author

Hi @KlattG ,

Would you review the new message here, please?
https://github.com/SAP/ui5-linter/pull/448/files#diff-09701c0232493655601b38f00fc2ebafebdf513a2aaf652ef5d440d1ea3ee04dR555

Cheers

KlattG
KlattG approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@KlattG KlattG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KlattG KlattG KlattG approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d3xter666 @KlattG