feat(linter): Extend project initialization fallbacks #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeworrior
reviewed
Dec 13, 2024
src/linter/linter.ts
Outdated
| } else if (await dirExists(path.join(rootDir, "WebContent"))) { | ||
| // Legacy app with WebContent folder | ||
| rootConfiguration = createProjectConfig("application", "WebContent"); | ||
| } else if (await dirExists(path.join(rootDir, "src", "main", "jslib"))) { |
There was a problem hiding this comment.
In the "big set", I found one project with src/main/js/ (AP-FIORI-CORE/nw.core.ushell_abap), it's not correctly handled by the logic that I've shared.
src/main/jslib, src/main/uilib don't occur in the "big set", but in SAPUI5 contributor libs.
For WebContent, I couldn't find an example, I guess this structure was used by very old tools and might occur in BSP repos only, not on GitHub.
There was a problem hiding this comment.
Thanks. I added src/main/js as well as main/webapp which I spotted in severall apps
RandomByte
force-pushed
the
enhance-project-path-fallbacks
branch
3 times, most recently
from
813c924 to
344c61b
Compare
Enhance compatibility for legacy UI5 projects that do not include a ui5.yaml and do not use current best practice directory structures like 'webapp' for apps and 'src'/'test' for libraries. In addition to those directories we now also check and eventually use the following directories: Applications: * src/main/webapp * WebContent Libraries: * src/main/jslib (+ src/test/jslib) * src/main/uilib (+ src/test/uilib) * src/main/js (+ src/test/js)
RandomByte
force-pushed
the
enhance-project-path-fallbacks
branch
2 times, most recently
from
a8f7f63 to
a5c05b5
Compare
matz3
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance compatibility for legacy UI5 projects that do not include a
ui5.yaml and do not use current best practice directory structures like
'webapp' for apps and 'src'/'test' for libraries.
In addition to those directories we now also check and eventually use
the following directories:
Applications:
Libraries: