Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Detect deprecations in new expressions with ID #437

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

matz3
Copy link
Member

@matz3 matz3 commented Dec 3, 2024

This solves the gap of not detecting usage of deprecated UI5 metadata
(e.g. properties, aggregations, events) when using the constructor
with an ID as first argument.

@matz3 matz3 requested a review from a team December 3, 2024 15:19
d3xter666
d3xter666 previously approved these changes Dec 4, 2024
Copy link
Contributor

@d3xter666 d3xter666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This solves the gap of not detecting usage of deprecated UI5 metadata
(e.g. properties, aggregations, events) when using the constructor
with an ID as first argument.
@matz3 matz3 force-pushed the fix-detect-deprecated-property branch from 38707c1 to f804d6f Compare December 4, 2024 10:08
@matz3 matz3 requested a review from RandomByte December 4, 2024 10:13
@matz3 matz3 merged commit 156e747 into main Dec 4, 2024
13 checks passed
@matz3 matz3 deleted the fix-detect-deprecated-property branch December 4, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants