[INTERNAL] Minifier: Fix handling of input source maps of bundles #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently there are known cases where projects execute a UI5 Tooling build on a previous build result. In this case we will minify previously created (and already minified) preload bundles. The source maps associated with these bundles are index- (or "sectioned") source maps. Some section maps (for example those generated during the bundling) might be lacking the "names" array. Since this is fine for regular source map, I assume this should be fine for index source maps too. Apparently, Terser fails to parse these source maps as of today. Therefore we will manually add the missing "names" array for the time being.
Declare source maps as JSON instead of strings
matz3
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently there are known cases where projects execute a UI5 Tooling build on a previous build result. In this case we will minify previously created (and already minified) preload bundles.
The source maps associated with these bundles are index- (or "sectioned") source maps. Some section maps (for example those generated during the bundling) might be lacking the "names" array. Since this is fine for regular source map, I assume this should be fine for index source maps too.
Apparently, Terser fails to parse these source maps as of today. Therefore we will manually add the missing "names" array for the time being.
I proposed an upstream fix here:
jridgewell/trace-mapping#29