Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTERNAL] Task generateLibraryPreload: Exclude component preload artefacts from library preload #754

Merged
merged 2 commits into from
Jun 14, 2022
Merged

[INTERNAL] Task generateLibraryPreload: Exclude component preload artefacts from library preload #754

merged 2 commits into from
Jun 14, 2022

Conversation

flovogt
Copy link
Member

@flovogt flovogt commented May 23, 2022

No description provided.

@flovogt flovogt requested a review from matz3 May 23, 2022 15:25
@matz3 matz3 requested review from RandomByte and codeworrior May 25, 2022 09:00
@matz3
Copy link
Member

matz3 commented May 25, 2022

Looks good 👍🏻
But let's postpone merging this one until the larger PR #740 is merged.

The tests need to be updated, but they might be also affected by #740, so let's wait until then to update them.

@flovogt flovogt force-pushed the build-exclude-component-preload-artefacts branch from c0bb68f to 30880a1 Compare June 14, 2022 09:08
@coveralls
Copy link

coveralls commented Jun 14, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 89.406% when pulling 30880a1 on build-exclude-component-preload-artefacts into f448567 on next.

@flovogt flovogt merged commit 46e9454 into next Jun 14, 2022
@flovogt flovogt deleted the build-exclude-component-preload-artefacts branch June 14, 2022 09:15
@matz3 matz3 mentioned this pull request Jul 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz3 matz3 matz3 approved these changes

@RandomByte RandomByte Awaiting requested review from RandomByte

@codeworrior codeworrior Awaiting requested review from codeworrior

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flovogt @matz3 @coveralls