Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] builder: add test for builder JSDoc parameter #592

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

tobiasso85
Copy link
Contributor

Increase test coverage

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 94.172% when pulling 23a8c40 on builder-test-coverage into fe61d6e on master.

@RandomByte
Copy link
Member

A verb in the commit message would be nice 🙂 . Something like "Add".

🍒 on top would be some capital letters like "JSDoc"

@tobiasso85 tobiasso85 changed the title [INTERNAL] test: builder jsdoc flag test [INTERNAL] builder: add test for builder jsdoc flag Mar 4, 2021
@tobiasso85 tobiasso85 changed the title [INTERNAL] builder: add test for builder jsdoc flag [INTERNAL] builder: add test for builder JSDoc parameter Mar 4, 2021
Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be aware that the builder.js tests must write into separate target directories each. Currently, your new test Build library.j with jsdoc flag set uses the same target directory as Build library.j with JSDoc build only.

So it overwrites the build result of the previous test but apparently does not delete any files.

If you change the target to an isolated directory you will find that no JSDoc resources are generated, because the excludedTasks: ["*"] parameter overrules the jsdoc: true flat and excludes all JSDoc tasks.

The jsdoc flag already excludes all unrelated tasks. So there's no need to use the excludedTasks parameter. After all, the UI5 CLI doesn't use it as well.

@RandomByte RandomByte changed the base branch from master to v2 November 3, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants