[INTERNAL] JSDoc: Fix reference to jsdoc template #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdoc is not able to resolve the @ui5/builder dependency when there is no @ui5/builder within node_modules available. This only became an issue once @ui5/project switched to an optional peerDependency for @ui5/builder so when testing the @ui5/builder itself, there was no transitive @ui5/builder dependency available. This also solves the issue of not testing the current version of the template as before it came from the installed @ui5/builder version. This also updates the package-lock.json by re-generating it.
RandomByte
approved these changes
Jul 23, 2024
RandomByte
added a commit
to SAP/ui5-tooling
that referenced
this pull request
Jul 23, 2024
RandomByte
added a commit
to SAP/ui5-tooling
that referenced
this pull request
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsdoc is not able to resolve the @ui5/builder dependency when there is no @ui5/builder within node_modules available. This only became an issue once @ui5/project switched to an optional peerDependency for @ui5/builder so when testing the @ui5/builder itself, there was no transitive @ui5/builder dependency available.
This also solves the issue of not testing the current version of the template as before it came from the installed @ui5/builder version.
This also updates the package-lock.json by re-generating it.