[INTERNAL] Bump eslint from 8.57.0 to 9.8.0 + Add common ESLint config (

#1076)

Bumps [eslint](https://github.com/eslint/eslint) from 8.57.0 to 9.8.0.

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Max Reichmann <[email protected]>

eslint.common.config.js

@@ -0,0 +1,99 @@
+import jsdoc from "eslint-plugin-jsdoc";
+import ava from "eslint-plugin-ava";
+import globals from "globals";
+import js from "@eslint/js";
+import google from "eslint-config-google";
+
+export default [{
+	ignores: [ // Common ignore patterns across all tooling repos
+		"**/coverage/",
+		"test/tmp/",
+		"test/expected/",
+		"test/fixtures/",
+		"**/docs/",
+		"**/jsdocs/",
+	],
+}, js.configs.recommended, google, ava.configs["flat/recommended"], {
+	name: "Common ESLint config used for all tooling repos",
+
+	plugins: {
+		jsdoc,
+	},
+
+	languageOptions: {
+		globals: {
+			...globals.node,
+		},
+
+		ecmaVersion: 2023,
+		sourceType: "module",
+	},
+
+	settings: {
+		jsdoc: {
+			mode: "jsdoc",
+
+			tagNamePreference: {
+				return: "returns",
+				augments: "extends",
+			},
+		},
+	},
+
+	rules: {
+		"indent": ["error", "tab"],
+		"linebreak-style": ["error", "unix"],
+
+		"quotes": ["error", "double", {
+			allowTemplateLiterals: true,
+		}],
+
+		"semi": ["error", "always"],
+		"no-negated-condition": "off",
+		"require-jsdoc": "off",
+		"no-mixed-requires": "off",
+
+		"max-len": ["error", {
+			code: 120,
+			ignoreUrls: true,
+			ignoreRegExpLiterals: true,
+		}],
+
+		"no-implicit-coercion": [2, {
+			allow: ["!!"],
+		}],
+
+		"comma-dangle": "off",
+		"no-tabs": "off",
+		"no-console": 2, // Disallow console.log()
+		"no-eval": 2,
+		// The following rule must be disabled as of ESLint 9.
+		// It's removed and causes issues when present
+		// https://eslint.org/docs/latest/rules/valid-jsdoc
+		"valid-jsdoc": 0,
+		"jsdoc/check-examples": 0,
+		"jsdoc/check-param-names": 2,
+		"jsdoc/check-tag-names": 2,
+		"jsdoc/check-types": 2,
+		"jsdoc/no-undefined-types": 0,
+		"jsdoc/require-description": 0,
+		"jsdoc/require-description-complete-sentence": 0,
+		"jsdoc/require-example": 0,
+		"jsdoc/require-hyphen-before-param-description": 0,
+		"jsdoc/require-param": 2,
+		"jsdoc/require-param-description": 0,
+		"jsdoc/require-param-name": 2,
+		"jsdoc/require-param-type": 2,
+		"jsdoc/require-returns": 0,
+		"jsdoc/require-returns-description": 0,
+		"jsdoc/require-returns-type": 2,
+
+		"jsdoc/tag-lines": [2, "any", {
+			startLines: 1,
+		}],
+
+		"jsdoc/valid-types": 0,
+		"ava/assertion-arguments": 0,
+	},
+}
+];

eslint.config.js

@@ -0,0 +1,12 @@
+import eslintCommonConfig from "./eslint.common.config.js";
+
+export default [
+	...eslintCommonConfig, // Load common ESLint config
+	{
+		// Add project-specific ESLint config rules here
+		// in order to override common config
+		ignores: [
+			"lib/processors/jsdoc/lib",
+		]
+	}
+];

lib/lbt/analyzer/XMLTemplateAnalyzer.js

@@ -402,7 +402,7 @@ class XMLTemplateAnalyzer {
 					}
 				}
 			}
-		} catch (err) {
+		} catch {
 			// ignore missing resources
 			// console.warn( "node not found %s", moduleName);
 		}

lib/lbt/bundle/Builder.js

@@ -636,7 +636,7 @@ class BundleBuilder {
 				let resource = null;
 				try {
 					resource = await this.pool.findResourceWithInfo(module);
-				} catch (e) {
+				} catch {
 					log.error(`    couldn't find ${module}`);
 				}
 

lib/lbt/resources/ResourceCollector.js

@@ -140,7 +140,7 @@ class ResourceCollector {
 					let subModuleInfo;
 					try {
 						subModuleInfo = await this._pool.getModuleInfo(subModule);
-					} catch (err) {
+					} catch {
 						log.verbose(`	Missing submodule ${subModule} included by ${moduleInfo.name}`);
 					}
 					if (subModuleInfo) {

lib/processors/manifestEnhancer.js

@@ -15,7 +15,7 @@ function isAbsoluteUrl(url) {
 		const parsedUrl = new URL(url);
 		// URL with ui5 protocol shouldn't be treated as absolute URL and will be handled separately
 		return parsedUrl.protocol !== "ui5:";
-	} catch (err) {
+	} catch {
 		// URL constructor without base requires absolute URL and throws an error for relative URLs
 		return false;
 	}

lib/tasks/bundlers/generateFlexChangesBundle.js

@@ -74,6 +74,7 @@ export default async function({workspace, taskUtil, options = {}}) {
 		manifestContent["sap.ui5"].dependencies = manifestContent["sap.ui5"].dependencies || {};
 		if (!Array.isArray(manifestContent["sap.ui5"].dependencies.minUI5Version)) {
 			manifestContent["sap.ui5"].dependencies.minUI5Version =
+				// eslint-disable-next-line no-constant-binary-expression
 				[manifestContent["sap.ui5"].dependencies.minUI5Version] || [""];
 		}
 		return manifestContent["sap.ui5"].dependencies.minUI5Version;