fix(environment): adjust getEnvironment exception handling (#89)

Refs: #84 Reviewed-By: Evelyn Gurschler <[email protected]>
SAP · Sep 12, 2024 · 8b526a5 · 8b526a5
1 parent d44ef09
commit 8b526a5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/clients/Dim.Clients/Api/Cf/CfClient.cs b/src/clients/Dim.Clients/Api/Cf/CfClient.cs
@@ -80,9 +80,9 @@ private static async Task<Guid> GetEnvironmentId(string tenantName, Cancellation
             .ConfigureAwait(false);
 
         var tenantEnvironment = environments?.Resources.Where(x => x.Name == tenantName);
-        if (tenantEnvironment == null || tenantEnvironment.Count() > 1)
+        if (tenantEnvironment == null || tenantEnvironment.Count() != 1)
         {
-            throw new ConflictException($"There should only be one cf environment for tenant {tenantName}");
+            throw new ServiceException($"There should only be one cf environment for tenant {tenantName}", true);
         }
 
         return tenantEnvironment.Single().EnvironmentId;

diff --git a/src/clients/Dim.Clients/Api/Entitlements/EntitlementClient.cs b/src/clients/Dim.Clients/Api/Entitlements/EntitlementClient.cs
@@ -48,6 +48,6 @@ public async Task AssignEntitlements(BasicAuthSettings basicAuthSettings, Guid s
             );
 
         await client.PutAsJsonAsync("/entitlements/v1/subaccountServicePlans", data, JsonSerializerExtensions.Options, cancellationToken)
-            .CatchingIntoServiceExceptionFor("assign-entitlements", HttpAsyncResponseMessageExtension.RecoverOptions.INFRASTRUCTURE).ConfigureAwait(false);
+            .CatchingIntoServiceExceptionFor("assign-entitlements", HttpAsyncResponseMessageExtension.RecoverOptions.ALLWAYS).ConfigureAwait(false);
     }
 }