-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CXSPA-8725: fix test isolation #19442
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Uli-Tiger,
could you, please, consider my tiny suggestions?
@@ -122,11 +123,12 @@ class MockProductService { | |||
} | |||
} | |||
|
|||
describe('ConfiguratorStorefrontUtilsService', () => { | |||
fdescribe('ConfiguratorStorefrontUtilsService', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, remove f-
prefix to run all tests. ;)
uiType: Configurator.UiType.RADIOBUTTON, | ||
values: [], | ||
}; | ||
let attribute: Configurator.Attribute; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, move this attribute to the top, namely declare this attribute directly after describe('focusValue', () => {
line 369.
No description provided.