-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CXSPA-8678: fix test isolation for ConfiguratorCartEntryBundleInfoComponent #19441
base: develop
Are you sure you want to change the base?
CXSPA-8678: fix test isolation for ConfiguratorCartEntryBundleInfoComponent #19441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Uli-Tiger,
could you, please, consider my tiny suggestion?
@@ -259,20 +259,22 @@ describe('ConfiguratorCartEntryBundleInfoComponent', () => { | |||
|
|||
describe('isBundleBasedConfigurator', () => { | |||
it('should return false because the configurator type is not bundle based one', () => { | |||
let testEntry = structuredClone(entry); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about renaming the variable to modified
- or clonedEntry
? The same for the next two tests. :)
No description provided.