Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixing sonar issues #19434

Merged
merged 4 commits into from
Oct 24, 2024
Merged

fix: Fixing sonar issues #19434

merged 4 commits into from
Oct 24, 2024

Conversation

rmch91
Copy link
Contributor

@rmch91 rmch91 commented Oct 23, 2024

@rmch91 rmch91 requested a review from a team as a code owner October 23, 2024 13:58
@github-actions github-actions bot marked this pull request as draft October 23, 2024 13:58
@rmch91 rmch91 marked this pull request as ready for review October 24, 2024 09:52
@cypress Cypress
Copy link

cypress bot commented Oct 24, 2024 •
edited
Loading

spartacus    Run #45481

Run Properties:  status check passed Passed #45481  •  git commit 6ee133caa0 ℹ️: Merge 7f65e06bb2b97f27d9ddcf2aa4b7a26b4c611d9a into 0bf6413b6ec104ba13c955b6bd10...
Project spartacus
Branch Review fix/CXSPA-8711
Run status status check passed Passed #45481
Run duration 03m 47s
Commit git commit 6ee133caa0 ℹ️: Merge 7f65e06bb2b97f27d9ddcf2aa4b7a26b4c611d9a into 0bf6413b6ec104ba13c955b6bd10...
Committer Roman
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
View all changes introduced in this branch ↗︎

@github-actions github-actions bot marked this pull request as draft October 24, 2024 11:32
@rmch91 rmch91 marked this pull request as ready for review October 24, 2024 11:32
@rmch91 rmch91 merged commit c812aae into develop Oct 24, 2024
28 checks passed
@rmch91 rmch91 deleted the fix/CXSPA-8711 branch October 24, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Platonn Platonn Platonn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmch91 @Platonn