Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (CXSPA-8185) - Password visibility switch, input value overflow fix #19424

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

fix: (CXSPA-8185) - Password visibility switch, input value overflow fix #19424

wants to merge 4 commits into from

Conversation

Pio-Bar
Copy link
Contributor

@Pio-Bar Pio-Bar commented Oct 22, 2024

Closes: CXSPA-8185

The input's value should no longer obstruct the password visibility switch.

@Pio-Bar Pio-Bar requested review from a team as code owners October 22, 2024 11:09
@github-actions github-actions bot marked this pull request as draft October 22, 2024 11:09
@Pio-Bar Pio-Bar marked this pull request as ready for review October 22, 2024 11:09
@cypress Cypress
Copy link

cypress bot commented Oct 22, 2024 •
edited
Loading

spartacus    Run #45437

Run Properties:  status check passed Passed #45437  •  git commit 75c182247f ℹ️: Merge bcf32f817903014368b087d1f12064002c51b04b into 071d8bfbd1b22ef3dbf46485479d...
Project spartacus
Branch Review feature/CXSPA-8186
Run status status check passed Passed #45437
Run duration 04m 14s
Commit git commit 75c182247f ℹ️: Merge bcf32f817903014368b087d1f12064002c51b04b into 071d8bfbd1b22ef3dbf46485479d...
Committer PioBar
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
View all changes introduced in this branch ↗︎

@github-actions github-actions bot marked this pull request as draft October 22, 2024 11:33
@Pio-Bar Pio-Bar marked this pull request as ready for review October 22, 2024 11:33
@github-actions GitHub Actions
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft October 22, 2024 11:33
@Pio-Bar Pio-Bar marked this pull request as ready for review October 22, 2024 11:35
@Pio-Bar Pio-Bar changed the title fix: (CXSPA-8186) - Password visibility switch, input value overflow fix fix: (CXSPA-8185) - Password visibility switch, input value overflow fix Oct 22, 2024
@github-actions github-actions bot marked this pull request as draft October 22, 2024 13:35
@Pio-Bar Pio-Bar marked this pull request as ready for review October 22, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeyber Zeyber Zeyber approved these changes

@developpeurweb developpeurweb developpeurweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pio-Bar @Zeyber @developpeurweb