Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear persisted focus on entering configuration #19413

Merged
merged 5 commits into from
Oct 23, 2024

Conversation

steinsebastian
Copy link
Contributor

CXSPA-8638

@steinsebastian steinsebastian requested review from a team as code owners October 18, 2024 12:01
@github-actions github-actions bot marked this pull request as draft October 18, 2024 12:01
@steinsebastian steinsebastian marked this pull request as ready for review October 18, 2024 12:02
Copy link

cypress bot commented Oct 18, 2024

spartacus    Run #45394

Run Properties:  status check passed Passed #45394  •  git commit ff6cf91600 ℹ️: Merge d2d19386bdef42bf6c4fdd4d05fde27f4465ebf5 into 1499ec54a175d53f1b89b5ef28d1...
Project spartacus
Run status status check passed Passed #45394
Run duration 04m 12s
Commit git commit ff6cf91600 ℹ️: Merge d2d19386bdef42bf6c4fdd4d05fde27f4465ebf5 into 1499ec54a175d53f1b89b5ef28d1...
Committer steinsebastian
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125

@github-actions github-actions bot marked this pull request as draft October 18, 2024 12:18
Uli-Tiger
Uli-Tiger previously approved these changes Oct 18, 2024
Copy link
Contributor

@Uli-Tiger Uli-Tiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtme

Copy link
Contributor

@Larisa-Staroverova Larisa-Staroverova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steinsebastian, could you, please, rename the instance?
Otherwise, it looks really good.

@steinsebastian steinsebastian marked this pull request as ready for review October 23, 2024 13:14
@steinsebastian steinsebastian merged commit d4596af into develop Oct 23, 2024
28 checks passed
@steinsebastian steinsebastian deleted the feature/CXSPA-8638 branch October 23, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants