-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: (CXSPA-8048) - Remove narration of Updating Cart in AddedToCartDialog component #19380
base: develop
Are you sure you want to change the base?
Conversation
spartacus Run #45234
Run Properties:
|
Project |
spartacus
|
Run status |
Passed #45234
|
Run duration | 13m 56s |
Commit |
d451df5196 ℹ️: Merge 6dc9f774997e9667aa0ebdff76ff1115f0acc3c3 into 6eb3258c1308da9645c032aec6f5...
|
Committer | petarmarkov9449 |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
4
|
Pending |
2
|
Skipped |
0
|
Passing |
125
|
Upgrade your plan to view test results. |
@petarmarkov9449 for some reason, it seems we have a regression here. As per screenshot, the current branch narrates the Page Title as the dialog's title, as opposed to Both are inaccurate. The narration of the dialog's title must match whatever is visible as the dialog's title. E.g.,
Basically, if hidden narrations such as "Loading..." or "Updating Cart..." are getting in the way of matching the visible title with audible one, then please remove those hidden narrations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visual and Audible Dialog's Title should match. Please see previous comments and screenshots.
Ticket: CXSPA-8048
Remove narration of "Updating Cart ..." in AddedToCartDialog component