-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHAS. Prod Config. Fixes incomplete string escaping or encoding #19374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
giancorderoortiz
changed the title
Fix code scanning alert no. 40: Incomplete string escaping or encoding
GHAS. Fix code scanning alert no. 40: Incomplete string escaping or encoding
Oct 9, 2024
giancorderoortiz
changed the title
GHAS. Fix code scanning alert no. 40: Incomplete string escaping or encoding
GHAS. Prod Config. Fixes incomplete string escaping or encoding
Oct 9, 2024
spartacus Run #45313
Run Properties:
|
Project |
spartacus
|
Run status |
Passed #45313
|
Run duration | 04m 26s |
Commit |
6009f2a80c ℹ️: Merge bfff5f5d117ff3c07183d2451ff91b14cb9acc22 into 31e2bf5dd98d2f5b67a80e7014da...
|
Committer | Giancarlo Cordero Ortiz |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
6
|
Pending |
2
|
Skipped |
0
|
Passing |
125
|
Larisa-Staroverova
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/SAP/spartacus/security/code-scanning/40
To fix the problem, we need to ensure that all occurrences of the characters
>
,<
,≥
, and≤
in thevalueName
string are replaced. This can be achieved by using a regular expression with the global flag (g
). This change will ensure that every instance of these characters is replaced, not just the first one.Suggested fixes powered by Copilot Autofix. Review carefully before merging.