Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHAS. Prod Config. Fixes incomplete string escaping or encoding #19374

Merged
merged 7 commits into from
Oct 15, 2024

Conversation

giancorderoortiz
Copy link
Contributor

Fixes https://github.com/SAP/spartacus/security/code-scanning/40

To fix the problem, we need to ensure that all occurrences of the characters >, <, , and in the valueName string are replaced. This can be achieved by using a regular expression with the global flag (g). This change will ensure that every instance of these characters is replaced, not just the first one.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@giancorderoortiz
Copy link
Contributor Author

@giancorderoortiz giancorderoortiz changed the title Fix code scanning alert no. 40: Incomplete string escaping or encoding GHAS. Fix code scanning alert no. 40: Incomplete string escaping or encoding Oct 9, 2024
@giancorderoortiz giancorderoortiz changed the title GHAS. Fix code scanning alert no. 40: Incomplete string escaping or encoding GHAS. Prod Config. Fixes incomplete string escaping or encoding Oct 9, 2024
@giancorderoortiz giancorderoortiz marked this pull request as ready for review October 9, 2024 21:27
@giancorderoortiz giancorderoortiz requested review from a team as code owners October 9, 2024 21:27
Copy link

cypress bot commented Oct 9, 2024

spartacus    Run #45313

Run Properties:  status check passed Passed #45313  •  git commit 6009f2a80c ℹ️: Merge bfff5f5d117ff3c07183d2451ff91b14cb9acc22 into 31e2bf5dd98d2f5b67a80e7014da...
Project spartacus
Run status status check passed Passed #45313
Run duration 04m 26s
Commit git commit 6009f2a80c ℹ️: Merge bfff5f5d117ff3c07183d2451ff91b14cb9acc22 into 31e2bf5dd98d2f5b67a80e7014da...
Committer Giancarlo Cordero Ortiz
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 6
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125

@github-actions github-actions bot marked this pull request as draft October 10, 2024 10:38
@Larisa-Staroverova Larisa-Staroverova marked this pull request as ready for review October 10, 2024 10:41
@github-actions github-actions bot marked this pull request as draft October 10, 2024 11:55
@Larisa-Staroverova Larisa-Staroverova marked this pull request as ready for review October 10, 2024 11:59
@github-actions github-actions bot marked this pull request as draft October 10, 2024 13:31
@giancorderoortiz giancorderoortiz marked this pull request as ready for review October 11, 2024 16:41
@github-actions github-actions bot marked this pull request as draft October 15, 2024 12:36
@giancorderoortiz giancorderoortiz marked this pull request as ready for review October 15, 2024 12:54
@giancorderoortiz giancorderoortiz merged commit 1404d80 into develop Oct 15, 2024
27 of 28 checks passed
@giancorderoortiz giancorderoortiz deleted the feature/CXSPA-8632 branch October 15, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants