Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix console issue that appears after clicking on i-icon #19358

Merged
merged 6 commits into from
Oct 16, 2024

Conversation

Larisa-Staroverova
Copy link
Contributor

Closes CXSPA-8600

@Larisa-Staroverova Larisa-Staroverova requested a review from a team as a code owner October 8, 2024 11:28
@github-actions github-actions bot marked this pull request as draft October 8, 2024 11:29
@Larisa-Staroverova Larisa-Staroverova changed the title Add aria-modal attribute to popover Fix console issue that appears after clicking on i-icon Oct 9, 2024
@Larisa-Staroverova
Copy link
Contributor Author

@steinsebastian, could you, please, retest with the screen reader?

@Larisa-Staroverova Larisa-Staroverova marked this pull request as ready for review October 14, 2024 07:51
@Larisa-Staroverova Larisa-Staroverova requested a review from a team as a code owner October 14, 2024 07:51
Copy link

cypress bot commented Oct 14, 2024

spartacus    Run #45324

Run Properties:  status check passed Passed #45324  •  git commit 22c5d20a49 ℹ️: Merge 9dcc8a4c0c1bad21bb9885fe855f0b9d5cea4b3c into 7c15b1a2a05eb2de470fa86292ed...
Project spartacus
Run status status check passed Passed #45324
Run duration 04m 36s
Commit git commit 22c5d20a49 ℹ️: Merge 9dcc8a4c0c1bad21bb9885fe855f0b9d5cea4b3c into 7c15b1a2a05eb2de470fa86292ed...
Committer LarisaStar
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125

@github-actions github-actions bot marked this pull request as draft October 16, 2024 04:29
@Larisa-Staroverova Larisa-Staroverova marked this pull request as ready for review October 16, 2024 04:33
@Larisa-Staroverova Larisa-Staroverova merged commit 121ea4b into develop Oct 16, 2024
28 checks passed
@Larisa-Staroverova Larisa-Staroverova deleted the feature/CXSPA-8600 branch October 16, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants