-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: (CXSPA-7997) - Change "QTY" into "Quantity" #19339
base: develop
Are you sure you want to change the base?
Conversation
spartacus Run #45451
Run Properties:
|
Project |
spartacus
|
Branch Review |
feature/CXSPA-7997
|
Run status |
Passed #45451
|
Run duration | 04m 18s |
Commit |
0868fc2f9d ℹ️: Merge 097c934d3c1eab018598aa5af6e300cf97a55c52 into c42053bf68bd6fcec3c819cd2f53...
|
Committer | petarmarkov9449 |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
4
|
Pending |
2
|
Skipped |
0
|
Passing |
125
|
View all changes introduced in this branch ↗︎ |
@@ -9,7 +9,7 @@ | |||
"description": "Description", | |||
"item": "Item", | |||
"itemPrice": "Item price", | |||
"quantity": "Qty", | |||
"quantity": "Quantity", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be careful about changing or removing properties already in use due to breaking changes (even translations).
Lets create a new property for "Quantity" to avoid making the breaking change and hide any use of the translation behind a feature toggle. You can do this in either the template or the service. It is similar to how you have already done with styles.
In template example:
// feature off
<ng-container *cxFeature="'!a11yQTY2Quantity'">
// show old content or translation
...
// feature on
<ng-container *cxFeature="'a11yQTY2Quantity'">
// show new
In service:
someMethod() {
...
if( this.featureConfigService.isEnabled('a11yQTY2Quantity') {
// Do something when feature flag is enabled
}
...
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated it.
Hey @petarmarkov9449, I still see "Qty", can you please make sure the Feature Flag is enabled. Thanks! |
...te/types/numeric-input-field/configurator-attribute-numeric-input-field.component.service.ts
Fixed
Show fixed
Hide fixed
...te/types/numeric-input-field/configurator-attribute-numeric-input-field.component.service.ts
Fixed
Show fixed
Hide fixed
25217fb
to
8f44860
Compare
{{ 'cartItems.quantityFull' | cxTranslate }} | ||
</div> | ||
<div | ||
*cxFeature="" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feature flag name is missing here ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated it.
"quantityFull": "Quantity", | ||
"itemPrice": "Item price", | ||
"qty": "Qty", | ||
"qtyFull": "Quantity", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need copies of the same string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated it.
{{ 'savedCartList.quantityFull' | cxTranslate }} | ||
</th> | ||
<th | ||
*cxFeature="'a11yQTY2Quantity'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*cxFeature="'a11yQTY2Quantity'" | |
*cxFeature="'!a11yQTY2Quantity'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, there was a typo. ;)
I've just fixed it.
Ticket: CXSPA-7997
Change "QTY" into "Quantity"