fix: (CXSPA-7997) - Change "QTY" into "Quantity" #19339
Conversation
spartacus
|
||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
feature/CXSPA-7997
|
| Run status |
|
| Run duration | 04m 18s |
| Commit |
|
| Committer | petarmarkov9449 |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
| View all changes introduced in this branch ↗︎ | |
| @@ -9,7 +9,7 @@ | |||
| "description": "Description", | |||
| "item": "Item", | |||
| "itemPrice": "Item price", | |||
| "quantity": "Qty", | |||
| "quantity": "Quantity", | |||
There was a problem hiding this comment.
We should be careful about changing or removing properties already in use due to breaking changes (even translations).
Lets create a new property for "Quantity" to avoid making the breaking change and hide any use of the translation behind a feature toggle. You can do this in either the template or the service. It is similar to how you have already done with styles.
In template example:
// feature off
<ng-container *cxFeature="'!a11yQTY2Quantity'">
// show old content or translation
...
// feature on
<ng-container *cxFeature="'a11yQTY2Quantity'">
// show new
In service:
someMethod() {
...
if( this.featureConfigService.isEnabled('a11yQTY2Quantity') {
// Do something when feature flag is enabled
}
...
}
There was a problem hiding this comment.
I've updated it.
|
Hey @petarmarkov9449, I still see "Qty", can you please make sure the Feature Flag is enabled. Thanks! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...te/types/numeric-input-field/configurator-attribute-numeric-input-field.component.service.ts
Fixed
Show fixed
Hide fixed
...te/types/numeric-input-field/configurator-attribute-numeric-input-field.component.service.ts
Fixed
Show fixed
Hide fixed
petarmarkov9449
force-pushed
the
feature/CXSPA-7997
branch
from
25217fb
to
8f44860
Compare
| {{ 'cartItems.quantityFull' | cxTranslate }} | ||
| </div> | ||
| <div | ||
| *cxFeature="" |
There was a problem hiding this comment.
Feature flag name is missing here ;)
There was a problem hiding this comment.
Updated it.
| "quantityFull": "Quantity", | ||
| "itemPrice": "Item price", | ||
| "qty": "Qty", | ||
| "qtyFull": "Quantity", |
There was a problem hiding this comment.
Do we need copies of the same string?
There was a problem hiding this comment.
Updated it.
| {{ 'savedCartList.quantityFull' | cxTranslate }} | ||
| </th> | ||
| <th | ||
| *cxFeature="'a11yQTY2Quantity'" |
There was a problem hiding this comment.
| *cxFeature="'a11yQTY2Quantity'" | |
| *cxFeature="'!a11yQTY2Quantity'" |
There was a problem hiding this comment.
Oh, there was a typo. ;)
I've just fixed it.
Ticket: CXSPA-7997
Change "QTY" into "Quantity"