-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: (CXSPA-8033) add aria hidden attribute to 'required' asterisks #19327
fix: (CXSPA-8033) add aria hidden attribute to 'required' asterisks #19327
Conversation
StanislavSukhanov
commented
Oct 3, 2024
- closes https://jira.tools.sap/browse/CXSPA-8033
spartacus Run #45378
Run Properties:
|
Project |
spartacus
|
Run status |
Passed #45378
|
Run duration | 04m 28s |
Commit |
41ac514605 ℹ️: Merge 7f855f4a204d4dca2e786f38d138bbbc478084e3 into cdc23a2c36ae6c3157f8dcf64bf8...
|
Committer | Stanislav Sukhanov |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
3
|
Pending |
2
|
Skipped |
0
|
Passing |
125
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just add the attribute to the abbr
, otherwise you can enter the empty group in read mode. We need to make sure the information about the field being required is still included somewhere. 🤔
|
||
<ng-template #requiredAsterisk> | ||
<abbr | ||
*cxFeature="'a11yRequiredAsterisks'" | ||
class="text-decoration-none" | ||
title="{{ 'common.required' | cxTranslate }}" | ||
>*</abbr | ||
> | ||
</ng-template> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good on you for cleaning it up, somebody must have left it here while removing the asterisks from the login page. 🤷
@Pio-Bar fixed. The 'required' is still being narrated. It's being picked up by an inputs required attribute. |
@StanislavSukhanov your solution works well on JAWS. Now, let's complete the auditor's full request, so please bring back the Login and Reset Password asterisk removed on CXSPA-7418 and apply your solution there as well. I have left a comment on that ticket explaining why we can't remove audited content. |
* moved aria-hidden to abbr tag. * The 'required' word is still being narrated by picking up input's required attribute * closes https://jira.tools.sap/browse/CXSPA-8033
* restored asterisks on ForgotPassword and LoginForm * closes https://jira.tools.sap/browse/CXSPA-8033
a691380
9361c7f
to
a691380
Compare
@developpeurweb It's done. Please have a look on that once again 🙏 |