Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/cxcds 12248 redesign search spa #19260

Merged
merged 119 commits into from
Oct 16, 2024
Merged

Feature/cxcds 12248 redesign search spa #19260

merged 119 commits into from
Oct 16, 2024

Conversation

lasoh
Copy link
Contributor

@lasoh lasoh commented Sep 18, 2024

No description provided.

c5346163 and others added 30 commits April 16, 2024 15:20
@c5346163
Add Trending Searches to search box component
d68aa4f
@c5346163
Improve code quality
cb7f016
@c5346163
Merge branch 'develop' of https://github.com/SAP/spartacus into CXCDS…
48c9e21 
…-11272

# Conflicts:
#	projects/storefrontlib/cms-components/navigation/search-box/search-box.module.ts
@c5346163
Remove feature references from the search box module
126c8c9
@darvsorceix
Merge branch 'develop' into CXCDS-11272
446657a
@c5346163
Update unit tests
b6320e6
@darvsorceix
Merge branch 'develop' into CXCDS-11272
3222d19
@c5346163
Apply prettier
0510e67
@darvsorceix
Merge branch 'develop' into CXCDS-11272
d904ba0
@c5346163
Update code structure
21d096c
@github-actions
Add license header
862ccbf
@darvsorceix
Merge branch 'develop' into CXCDS-11272
b8bb3db
@c5346163
Add unit tests for trending searches component and service, restructu…
8230189 
…re model folder
@c5346163
Remove hardcoded product link
c7950d9
@darvsorceix
Merge branch 'develop' into CXCDS-11272
942cf83
@pekura
CXCDS-11272 - UX design improvements applied
6cae650
@pekura
CXCDS-11272 - feature toggle added to interface; default values added
fee6155
@pekura
Merge branch 'develop' into CXCDS-11272
3c78eb0
@pekura
CXCDS-11272 - UX design minor improvement applied
2afd93c
@pekura
Merge branch 'develop' into CXCDS-11272
32dec59 
# Conflicts:
#	projects/storefrontlib/cms-components/navigation/search-box/search-box.component.html
@pekura
Merge branch 'develop' into CXCDS-11272
72a6069
@lasoh1985
CXCDS-12248 first look
960b225
@lasoh1985
Merge branch 'develop' into feature/CXCDS-12248-redesign-search-spa
0346045 
# Conflicts:
#	projects/core/src/features-config/feature-toggles/config/feature-toggles.ts
@lasoh1985
Merge branch 'develop' into feature/CXCDS-12248-redesign-search-spa
2b68390
@lasoh1985
CXCDS-12248 keybord navigation
243b901
@lasoh1985
Merge branch 'develop' into feature/CXCDS-12248-redesign-search-spa
28f20bf 
# Conflicts:
#	projects/core/src/features-config/feature-toggles/config/feature-toggles.ts
@lasoh1985
CXCDS-12248 keybord navigation => carouel stopPropagation
938d0cd
@pekura
Merge branch 'develop' into CXCDS-11272
9b07acc
@darvsorceix @c5346163 @pekura
feat: CXCDS-12079 Improve searchBox handling for Trending Searches in…
2eb53ac 
… SPA (#19010)

Co-authored-by: Konrad Dzikowski <[email protected]>
Co-authored-by: Peter Kurajsky <[email protected]>
@pekura @c5346163
Cxcds 12079 (#19242)
021b277 
Co-authored-by: Konrad Dzikowski <[email protected]>
@lasoh lasoh marked this pull request as ready for review October 15, 2024 07:03
@github-actions GitHub Actions
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft October 15, 2024 08:29
@pekura pekura marked this pull request as ready for review October 15, 2024 08:29
@github-actions GitHub Actions
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft October 15, 2024 11:41
@pekura pekura marked this pull request as ready for review October 15, 2024 11:41
@github-actions GitHub Actions
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft October 15, 2024 13:24
@pekura pekura marked this pull request as ready for review October 15, 2024 13:48
@github-actions github-actions bot marked this pull request as draft October 15, 2024 14:31
@pekura pekura marked this pull request as ready for review October 15, 2024 14:32
@lasoh lasoh requested a review from rmch91 October 15, 2024 14:47
@github-actions github-actions bot marked this pull request as draft October 15, 2024 15:31
@pekura pekura marked this pull request as ready for review October 15, 2024 15:32
@github-actions github-actions bot marked this pull request as draft October 16, 2024 07:57
@pekura pekura marked this pull request as ready for review October 16, 2024 08:00
@lasoh lasoh merged commit d9fc090 into develop Oct 16, 2024
28 checks passed
@lasoh lasoh deleted the feature/CXCDS-12248-redesign-search-spa branch October 16, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmch91 rmch91 rmch91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lasoh @rmch91 @c5346163 @darvsorceix @pekura @lasoh1985