Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mcs customer login with CDC hosted page #19138

Draft
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

i53577
Copy link
Contributor

@i53577 i53577 commented Aug 15, 2024

No description provided.

i53577 and others added 2 commits August 15, 2024 10:19
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…9139)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@i53577 i53577 marked this pull request as ready for review August 15, 2024 06:18
@i53577 i53577 requested review from a team as code owners August 15, 2024 06:18
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft August 15, 2024 06:59
@i53577 i53577 marked this pull request as ready for review September 3, 2024 09:04
@i53577 i53577 requested a review from a team as a code owner September 3, 2024 09:04
Copy link

cypress bot commented Sep 3, 2024

spartacus    Run #44738

Run Properties:  status check passed Passed #44738  •  git commit 9eff0f1dd9 ℹ️: Merge fced029b882f16049428e6b7060202a3a1922a1e into e023b6f4e544b2d92f372936476e...
Project spartacus
Branch Review feature/mcs-cdc-login
Run status status check passed Passed #44738
Run duration 03m 56s
Commit git commit 9eff0f1dd9 ℹ️: Merge fced029b882f16049428e6b7060202a3a1922a1e into e023b6f4e544b2d92f372936476e...
Committer Grace Dong
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 5
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 121
View all changes introduced in this branch ↗︎

@github-actions github-actions bot marked this pull request as draft September 3, 2024 10:05
@i53577 i53577 marked this pull request as ready for review September 4, 2024 03:35
@github-actions github-actions bot marked this pull request as draft September 4, 2024 05:40
@i53577 i53577 marked this pull request as ready for review September 4, 2024 09:38
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft September 5, 2024 02:58
@NgModule({
imports: [CdcRootModule],
providers: [
provideConfig(<CdcConfig>{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code in here may block the original CDC implementation.

*
* Completes after emitting the value.
*/
protected resolveConfig(): Observable<CdcConfig> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this code only work in MCS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants