Skip to content

Commit

Permalink
Merge branch 'develop' into feature/GH-14925_enable_codeql
Browse files Browse the repository at this point in the history
  • Loading branch information
giancorderoortiz authored Nov 10, 2023
2 parents 6695db7 + dfcd448 commit e2b7f37
Show file tree
Hide file tree
Showing 675 changed files with 23,093 additions and 35,722 deletions.
59 changes: 34 additions & 25 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,17 @@
"root": true,
"overrides": [
{
"files": [
"*.ts"
],
"files": ["*.ts"],
"parserOptions": {
"project": [
"tsconfig.eslint.json"
],
"project": ["tsconfig.eslint.json"],
"createDefaultProgram": true
},
"extends": [
"plugin:@angular-eslint/ng-cli-compat",
"plugin:@angular-eslint/ng-cli-compat--formatting-add-on",
"plugin:@angular-eslint/template/process-inline-templates"
],
"plugins": [
"deprecation",
"@spartacus-eslint"
],
"plugins": ["deprecation", "@typescript-eslint", "@nrwl/nx"],
"rules": {
"@angular-eslint/no-host-metadata-property": "off",
"@typescript-eslint/no-empty-interface": "off",
Expand Down Expand Up @@ -74,32 +67,48 @@
"id-blacklist": "off",
"id-match": "off",
"max-len": "off",
"linebreak-style": [
"linebreak-style": ["error", "unix"],
"no-underscore-dangle": "off",
"@nrwl/nx/enforce-module-boundaries": [
"error",
"unix"
],
"no-underscore-dangle": "off"
{
"allow": [],
"depConstraints": [
{
"sourceTag": "*",
"onlyDependOnLibsWithTags": ["*"],
"notDependOnLibsWithTags": ["type:app"]
},
{
"sourceTag": "type:feature",
"notDependOnLibsWithTags": ["type:integration"]
},
{
"sourceTag": "type:ui",
"notDependOnLibsWithTags": ["type:feature"]
},
{
"sourceTag": "scope:core",
"notDependOnLibsWithTags": ["type:ui", "type:feature"]
}
]
}
]
}
},
{
"files": [
"*.html"
],
"extends": [
"plugin:@angular-eslint/template/recommended"
],
"files": ["*.html"],
"extends": ["plugin:@angular-eslint/template/recommended"],
"rules": {
"@angular-eslint/template/no-negated-async": "off",
"@angular-eslint/template/eqeqeq": "error"
}
},
{
"files": [
"*.module.ts"
],
"files": ["*.module.ts"],
"rules": {
"@spartacus-eslint/use-default-provide-config": "error"
"@nrwl/nx/workspace/use-default-provide-config": "error"
}
}
]
}
}
9 changes: 7 additions & 2 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
# ================================================
# ASM
# ================================================
/feature-libs/asm/ @SAP/spartacus-codeowners @SAP/spartacus-iceman
/feature-libs/asm/ @SAP/spartacus-codeowners @SAP/spartacus-holidays

# ================================================
# Product Configurator and CPQ integration
Expand All @@ -60,8 +60,13 @@
# ================================================
/integration-libs/cds/ @SAP/spartacus-codeowners @SAP/spartacus-CDS

# ================================================
# (CDC)
# ================================================
/integration-libs/cdc/ @SAP/spartacus-codeowners @SAP/spartacus-CDC

# ================================================
# BOPIS Feature
# BOPIS
# ================================================
/feature-libs/pickup-in-store/ @SAP/spartacus-codeowners @SAP/spartacus-colossus

Loading

0 comments on commit e2b7f37

Please sign in to comment.