Skip to content

Commit

Permalink
fix: Update unit tests coverage
Browse files Browse the repository at this point in the history
Closes: CXSPA-4616, CXSPA-4614
  • Loading branch information
Matejk00 authored Sep 11, 2023
1 parent e1586cd commit a06eac9
Show file tree
Hide file tree
Showing 2 changed files with 160 additions and 160 deletions.
Original file line number Diff line number Diff line change
@@ -1,85 +1,85 @@
// /*
// * SPDX-FileCopyrightText: 2023 SAP Spartacus team <[email protected]>
// *
// * SPDX-License-Identifier: Apache-2.0
// */

// import { TestBed } from '@angular/core/testing';
// import { OpfPaymentMetadata } from '../model';
// import { OpfPaymentMetadataStoreService } from './opf-payment-metadata-store.service';

// const initialState = {
// termsAndConditionsChecked: false,
// selectedPaymentOptionId: undefined,
// isPaymentInProgress: false,
// };

// const state: OpfPaymentMetadata = {
// isPaymentInProgress: true,
// selectedPaymentOptionId: 111,
// termsAndConditionsChecked: true,
// };

// describe('OpfPaymentMetadataStoreService', () => {
// let service: OpfPaymentMetadataStoreService;

// beforeEach(() => {
// TestBed.configureTestingModule({
// providers: [OpfPaymentMetadataStoreService],
// });

// service = TestBed.inject(OpfPaymentMetadataStoreService);
// });

// it('should be created', () => {
// expect(service).toBeTruthy();
// });

// it('should initialize with the initial state', () => {
// expect(service.opfPaymentMetadataState.value).toEqual(initialState);
// });

// it('should return the current opfPaymentMetadataState as an observable', (done) => {
// service.opfPaymentMetadataState.next(state);

// service.getOpfMetadataState().subscribe((state) => {
// expect(state).toEqual(state);
// done();
// });
// });

// it('should update opfPaymentMetadataState with the given payload', () => {
// const mockedState: OpfPaymentMetadata = {
// ...state,
// isPaymentInProgress: false,
// };

// service.opfPaymentMetadataState.next(mockedState);

// const updatedPayload = {
// isPaymentInProgress: true,
// termsAndConditionsChecked: false,
// };

// service.updateOpfMetadata(updatedPayload);

// expect(service.opfPaymentMetadataState.value).toEqual({
// ...mockedState,
// ...updatedPayload,
// });
// });

// it('should clear opfPaymentMetadataState and set it back to the initial state', () => {
// const state = {
// isPaymentInProgress: true,
// termsAndConditionsChecked: true,
// selectedPaymentOptionId: 111,
// };

// service.opfPaymentMetadataState.next(state);

// service.clearOpfMetadata();

// expect(service.opfPaymentMetadataState.value).toEqual(initialState);
// });
// });
/*
* SPDX-FileCopyrightText: 2023 SAP Spartacus team <[email protected]>
*
* SPDX-License-Identifier: Apache-2.0
*/

import { TestBed } from '@angular/core/testing';
import { OpfPaymentMetadata } from '../model';
import { OpfPaymentMetadataStoreService } from './opf-payment-metadata-store.service';

const initialState = {
termsAndConditionsChecked: false,
selectedPaymentOptionId: undefined,
isPaymentInProgress: false,
};

const state: OpfPaymentMetadata = {
isPaymentInProgress: true,
selectedPaymentOptionId: 111,
termsAndConditionsChecked: true,
};

describe('OpfPaymentMetadataStoreService', () => {
let service: OpfPaymentMetadataStoreService;

beforeEach(() => {
TestBed.configureTestingModule({
providers: [OpfPaymentMetadataStoreService],
});

service = TestBed.inject(OpfPaymentMetadataStoreService);
});

it('should be created', () => {
expect(service).toBeTruthy();
});

it('should initialize with the initial state', () => {
expect(service.opfPaymentMetadataState.value).toEqual(initialState);
});

it('should return the current opfPaymentMetadataState as an observable', (done) => {
service.opfPaymentMetadataState.next(state);

service.getOpfMetadataState().subscribe((state) => {
expect(state).toEqual(state);
done();
});
});

it('should update opfPaymentMetadataState with the given payload', () => {
const mockedState: OpfPaymentMetadata = {
...state,
isPaymentInProgress: false,
};

service.opfPaymentMetadataState.next(mockedState);

const updatedPayload = {
isPaymentInProgress: true,
termsAndConditionsChecked: false,
};

service.updateOpfMetadata(updatedPayload);

expect(service.opfPaymentMetadataState.value).toEqual({
...mockedState,
...updatedPayload,
});
});

it('should clear opfPaymentMetadataState and set it back to the initial state', () => {
const state = {
isPaymentInProgress: true,
termsAndConditionsChecked: true,
selectedPaymentOptionId: 111,
};

service.opfPaymentMetadataState.next(state);

service.clearOpfMetadata();

expect(service.opfPaymentMetadataState.value).toEqual(initialState);
});
});
150 changes: 75 additions & 75 deletions integration-libs/opf/base/root/services/opf.service.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,78 +10,78 @@
// * SPDX-License-Identifier: Apache-2.0
// */

// import { TestBed } from '@angular/core/testing';
// import { BehaviorSubject, Observable } from 'rxjs';
// import { OpfPaymentMetadata } from '../model';
// import { OpfPaymentMetadataStoreService } from './opf-payment-metadata-store.service';
// import { OpfService } from './opf.service';

// describe('OpfService', () => {
// let service: OpfService;
// let opfPaymentMetadataStoreServiceMock: jasmine.SpyObj<OpfPaymentMetadataStoreService>;

// beforeEach(() => {
// opfPaymentMetadataStoreServiceMock = jasmine.createSpyObj(
// 'OpfPaymentMetadataStoreService',
// ['updateOpfMetadata', 'clearOpfMetadata', 'getOpfMetadataState']
// );

// TestBed.configureTestingModule({
// providers: [
// OpfService,
// {
// provide: OpfPaymentMetadataStoreService,
// useValue: opfPaymentMetadataStoreServiceMock,
// },
// ],
// });

// service = TestBed.inject(OpfService);
// });

// it('should be created', () => {
// expect(service).toBeTruthy();
// });

// it('should call updateOpfMetadataState with the provided payload', () => {
// const mockOpfMetadata: Partial<OpfPaymentMetadata> = {
// isPaymentInProgress: true,
// };

// service.updateOpfMetadataState(mockOpfMetadata);

// expect(
// opfPaymentMetadataStoreServiceMock.updateOpfMetadata
// ).toHaveBeenCalledWith(mockOpfMetadata);
// });

// it('should call clearOpfMetadataState', () => {
// service.clearOpfMetadataState();

// expect(
// opfPaymentMetadataStoreServiceMock.clearOpfMetadata
// ).toHaveBeenCalled();
// });

// it('should call getOpfMetadataState and return the observable', () => {
// const mockOpfMetadata: OpfPaymentMetadata = {
// isPaymentInProgress: true,
// selectedPaymentOptionId: 111,
// termsAndConditionsChecked: true,
// };

// const mockObservable = new BehaviorSubject<OpfPaymentMetadata>(
// mockOpfMetadata
// );
// opfPaymentMetadataStoreServiceMock.getOpfMetadataState.and.returnValue(
// mockObservable
// );

// const result = service.getOpfMetadataState();

// expect(result).toBeInstanceOf(Observable);
// result.subscribe((metadata) => {
// expect(metadata).toEqual(mockOpfMetadata);
// });
// });
// });
import { TestBed } from '@angular/core/testing';
import { BehaviorSubject, Observable } from 'rxjs';
import { OpfPaymentMetadata } from '../model';
import { OpfPaymentMetadataStoreService } from './opf-payment-metadata-store.service';
import { OpfService } from './opf.service';

describe('OpfService', () => {
let service: OpfService;
let opfPaymentMetadataStoreServiceMock: jasmine.SpyObj<OpfPaymentMetadataStoreService>;

beforeEach(() => {
opfPaymentMetadataStoreServiceMock = jasmine.createSpyObj(
'OpfPaymentMetadataStoreService',
['updateOpfMetadata', 'clearOpfMetadata', 'getOpfMetadataState']
);

TestBed.configureTestingModule({
providers: [
OpfService,
{
provide: OpfPaymentMetadataStoreService,
useValue: opfPaymentMetadataStoreServiceMock,
},
],
});

service = TestBed.inject(OpfService);
});

it('should be created', () => {
expect(service).toBeTruthy();
});

it('should call updateOpfMetadataState with the provided payload', () => {
const mockOpfMetadata: Partial<OpfPaymentMetadata> = {
isPaymentInProgress: true,
};

service.updateOpfMetadataState(mockOpfMetadata);

expect(
opfPaymentMetadataStoreServiceMock.updateOpfMetadata
).toHaveBeenCalledWith(mockOpfMetadata);
});

it('should call clearOpfMetadataState', () => {
service.clearOpfMetadataState();

expect(
opfPaymentMetadataStoreServiceMock.clearOpfMetadata
).toHaveBeenCalled();
});

it('should call getOpfMetadataState and return the observable', () => {
const mockOpfMetadata: OpfPaymentMetadata = {
isPaymentInProgress: true,
selectedPaymentOptionId: 111,
termsAndConditionsChecked: true,
};

const mockObservable = new BehaviorSubject<OpfPaymentMetadata>(
mockOpfMetadata
);
opfPaymentMetadataStoreServiceMock.getOpfMetadataState.and.returnValue(
mockObservable
);

const result = service.getOpfMetadataState();

expect(result).toBeInstanceOf(Observable);
result.subscribe((metadata) => {
expect(metadata).toEqual(mockOpfMetadata);
});
});
});

0 comments on commit a06eac9

Please sign in to comment.