Skip to content

Commit

Permalink
fix: change attribute binding to property binding in GenericLink (#17684
Browse files Browse the repository at this point in the history
)

Changed attribute binding to property binding for target property in link html element in GenericLinkComponent.
In a case of usage of routerLink directive attribute binding of target property might not work as expected. Angular routerLink directive is designed to handle navigation and it takes precedence over the "target" attribute.
  • Loading branch information
rmch91 authored Jul 26, 2023
1 parent 321b332 commit 8a29feb
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
[routerLink]="routerUrl"
[queryParams]="queryParams"
[fragment]="fragment"
[attr.target]="target"
[target]="target || undefined"
[attr.id]="id"
[attr.class]="class"
[attr.style]="style"
Expand Down

0 comments on commit 8a29feb

Please sign in to comment.