-
Notifications
You must be signed in to change notification settings - Fork 386
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: fix insecure request exposing sensitive information (#18756)
- Loading branch information
1 parent
dd2c600
commit 77ba8c2
Showing
10 changed files
with
131 additions
and
75 deletions.
There are no files selected for viewing
32 changes: 0 additions & 32 deletions
32
feature-libs/cart/base/occ/adapters/default-occ-cart-config.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
feature-libs/cart/base/occ/config/default-occ-cart-config-factory.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
/* | ||
* SPDX-FileCopyrightText: 2024 SAP Spartacus team <[email protected]> | ||
* | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
import { FeatureToggles, OccConfig } from '@spartacus/core'; | ||
import { inject } from '@angular/core'; | ||
|
||
export function defaultOccCartConfigFactory(): OccConfig { | ||
const featureToggles = inject(FeatureToggles); | ||
|
||
return { | ||
backend: { | ||
occ: { | ||
endpoints: { | ||
/* eslint-disable max-len */ | ||
carts: | ||
'users/${userId}/carts?fields=carts(DEFAULT,potentialProductPromotions,appliedProductPromotions,potentialOrderPromotions,appliedOrderPromotions,entries(totalPrice(formattedValue),product(images(FULL),stock(FULL)),basePrice(formattedValue,value),updateable),totalPrice(formattedValue),totalItems,totalPriceWithTax(formattedValue),totalDiscounts(value,formattedValue),subTotal(formattedValue),totalUnitCount,deliveryItemsQuantity,deliveryCost(formattedValue),totalTax(formattedValue, value),pickupItemsQuantity,net,appliedVouchers,productDiscounts(formattedValue),user,saveTime,name,description)', | ||
cart: 'users/${userId}/carts/${cartId}?fields=DEFAULT,potentialProductPromotions,appliedProductPromotions,potentialOrderPromotions,appliedOrderPromotions,entries(totalPrice(formattedValue),product(images(FULL),stock(FULL)),basePrice(formattedValue,value),updateable),totalPrice(formattedValue),totalItems,totalPriceWithTax(formattedValue),totalDiscounts(value,formattedValue),subTotal(formattedValue),totalUnitCount,deliveryItemsQuantity,deliveryCost(formattedValue),totalTax(formattedValue, value),pickupItemsQuantity,net,appliedVouchers,productDiscounts(formattedValue),user,saveTime,name,description', | ||
createCart: | ||
'users/${userId}/carts?fields=DEFAULT,potentialProductPromotions,appliedProductPromotions,potentialOrderPromotions,appliedOrderPromotions,entries(totalPrice(formattedValue),product(images(FULL),stock(FULL)),basePrice(formattedValue,value),updateable),totalPrice(formattedValue),totalItems,totalPriceWithTax(formattedValue),totalDiscounts(value,formattedValue),subTotal(formattedValue),totalUnitCount,deliveryItemsQuantity,deliveryCost(formattedValue),totalTax(formattedValue, value),pickupItemsQuantity,net,appliedVouchers,productDiscounts(formattedValue),user', | ||
addEntries: 'users/${userId}/carts/${cartId}/entries', | ||
updateEntries: | ||
'users/${userId}/carts/${cartId}/entries/${entryNumber}', | ||
removeEntries: | ||
'users/${userId}/carts/${cartId}/entries/${entryNumber}', | ||
addEmail: 'users/${userId}/carts/${cartId}/email', | ||
deleteCart: 'users/${userId}/carts/${cartId}', | ||
cartVoucher: 'users/${userId}/carts/${cartId}/vouchers', | ||
saveCart: featureToggles.occCartNameAndDescriptionInHttpRequestBody | ||
? '/users/${userId}/carts/${cartId}/save' | ||
: '/users/${userId}/carts/${cartId}/save?saveCartName=${saveCartName}&saveCartDescription=${saveCartDescription}', | ||
validate: 'users/${userId}/carts/${cartId}/validate?fields=DEFAULT', | ||
/* eslint-enable */ | ||
}, | ||
}, | ||
}, | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
feature-libs/cart/saved-cart/occ/config/default-occ-saved-cart-config-factory.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
/* | ||
* SPDX-FileCopyrightText: 2024 SAP Spartacus team <[email protected]> | ||
* | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
import { FeatureToggles, OccConfig } from '@spartacus/core'; | ||
import { inject } from '@angular/core'; | ||
|
||
export function defaultOccSavedCartConfigFactory(): OccConfig { | ||
const featureToggles = inject(FeatureToggles); | ||
|
||
return { | ||
backend: { | ||
occ: { | ||
endpoints: { | ||
savedCarts: | ||
'/users/${userId}/carts?savedCartsOnly=true&fields=carts(DEFAULT,potentialProductPromotions,appliedProductPromotions,potentialOrderPromotions,appliedOrderPromotions,entries(totalPrice(formattedValue),product(images(FULL),stock(FULL)),basePrice(formattedValue,value),updateable),totalPrice(formattedValue),totalItems,totalPriceWithTax(formattedValue),totalDiscounts(value,formattedValue),subTotal(formattedValue),totalUnitCount,deliveryItemsQuantity,deliveryCost(formattedValue),totalTax(formattedValue, value),pickupItemsQuantity,net,appliedVouchers,productDiscounts(formattedValue),saveTime,user,name,description)', | ||
savedCart: '/users/${userId}/carts/${cartId}/savedcart', | ||
restoreSavedCart: '/users/${userId}/carts/${cartId}/restoresavedcart', | ||
cloneSavedCart: | ||
featureToggles.occCartNameAndDescriptionInHttpRequestBody | ||
? '/users/${userId}/carts/${cartId}/clonesavedcart' | ||
: '/users/${userId}/carts/${cartId}/clonesavedcart?name=${saveCartName}', | ||
}, | ||
}, | ||
}, | ||
}; | ||
} |
22 changes: 0 additions & 22 deletions
22
feature-libs/cart/saved-cart/occ/config/default-occ-saved-cart-config.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters