fix: Fix sonar issues (#19011)

SAP · Jun 28, 2024 · 2c46b37 · 2c46b37
1 parent e543cfa
commit 2c46b37
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 24 deletions.
diff --git a/feature-libs/pickup-in-store/styles/_pickup-option-dialog.scss b/feature-libs/pickup-in-store/styles/_pickup-option-dialog.scss
@@ -16,18 +16,16 @@
       }
 
       @extend .modal-content;
-      .cx-dialog-header {
-        .cx-dialog-title {
-          @include type('3');
-          margin-inline-start: var(--cx-margin-left, 0.875rem);
-        }
-      }
-
       .cx-dialog-header {
         margin-bottom: 0;
         padding-bottom: 0;
         border: none;
         margin-top: 1.15rem;
+
+        .cx-dialog-title {
+          @include type('3');
+          margin-inline-start: var(--cx-margin-left, 0.875rem);
+        }
       }
 
       .cx-dialog-body {

diff --git a/feature-libs/pickup-in-store/styles/_store-search.scss b/feature-libs/pickup-in-store/styles/_store-search.scss
@@ -20,13 +20,12 @@
     }
     .cx-find-a-store-button {
       flex-basis: 100%;
-      margin-top: 1rem;
-      margin-bottom: 1rem;
+      margin-top: 0;
+      margin-bottom: 0;
+
       @media screen and (min-width: 927px) {
         flex-basis: 40%;
       }
-      margin-top: 0;
-      margin-bottom: 0;
     }
     .cx-find-a-store-link-container {
       @include media-breakpoint-down(sm) {

diff --git a/projects/storefrontstyles/scss/components/content/navigation/_scroll-to-top.scss b/projects/storefrontstyles/scss/components/content/navigation/_scroll-to-top.scss
@@ -16,7 +16,6 @@
     height: inherit;
     width: inherit;
     font-size: 30px;
-    border-radius: 4px;
     color: var(--cx-color-inverse);
     background-color: var(--cx-color-primary);
     border: transparent;

diff --git a/projects/storefrontstyles/scss/components/layout/header/_header.scss b/projects/storefrontstyles/scss/components/layout/header/_header.scss
@@ -134,6 +134,14 @@ $space: 0.5rem;
 
   .cx-hamburger {
     display: block;
+
+    &.is-active {
+      .hamburger-inner,
+      .hamburger-inner::before,
+      .hamburger-inner::after {
+        background-color: var(--cx-color-primary);
+      }
+    }
   }
 
   @include media-breakpoint-only(xs) {
@@ -202,16 +210,6 @@ $space: 0.5rem;
     }
   }
 
-  .cx-hamburger {
-    &.is-active {
-      .hamburger-inner,
-      .hamburger-inner::before,
-      .hamburger-inner::after {
-        background-color: var(--cx-color-primary);
-      }
-    }
-  }
-
   .hamburger-inner,
   .hamburger-inner::before,
   .hamburger-inner::after {

diff --git a/projects/storefrontstyles/scss/components/layout/header/_site-context-selector.scss b/projects/storefrontstyles/scss/components/layout/header/_site-context-selector.scss
@@ -35,7 +35,6 @@ $caretSize: 7px;
   }
 
   select {
-    color: inherit;
     background-color: var(--cx-color-light);
     color: var(--cx-color-text);
     border: 0;

diff --git a/projects/storefrontstyles/scss/cxbase/blocks/buttons.scss b/projects/storefrontstyles/scss/cxbase/blocks/buttons.scss
@@ -196,7 +196,6 @@ button {
 
   &:focus {
     //this here below will not work unles cx global colors are initially declared in rbg
-    border-color: var(--cx-color-primary);
     box-shadow: 0 0 0 0.2em var(--cx-color-visual-focus);
     background-color: var(--cx-color-transparent);
     color: var(--cx-color-primary);