Use the HEAD method when fetching as it is more efficient and prevent…

…s 30-second delay when node exits. (#219) * Use the HEAD method when fetching as it is more efficient and prevents 30-second delay when node exits. * resolve conflict * make fetch method flexible * adapt tests --------- Co-authored-by: jliempt <> Co-authored-by: Jordi van Liempt <[email protected]>
SAP · Oct 30, 2024 · f8d534f · f8d534f
1 parent a21e55f
commit f8d534f
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 10 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/fetch.ts b/src/fetch.ts
@@ -4,11 +4,11 @@ export async function wait (delay: number): Promise<string> {
   return await new Promise((resolve) => setTimeout(resolve, delay))
 }
 
-export async function fetchRetry (url: string, tries = 5, baseDelayMS = 1000): Promise<Response> {
+export async function fetchRetry (url: string, method = 'GET', tries = 5, baseDelayMS = 1000): Promise<Response> {
   let attempt = 0
 
   while (tries > attempt) {
-    const response = await fetch(url)
+    const response = await fetch(url, { method })
     if (response.status === 200) {
       return response
     }

diff --git a/src/github.ts b/src/github.ts
@@ -154,7 +154,8 @@ export async function buildPiperFromSource (version: string): Promise<string> {
 }
 
 async function getPiperDownloadURL (piper: string, version?: string): Promise<string> {
-  const response = await fetchRetry(`${GITHUB_COM_SERVER_URL}/SAP/jenkins-library/releases/${getTag(false, version)}`).catch(async (err) => {
+  const tagURL = `${GITHUB_COM_SERVER_URL}/SAP/jenkins-library/releases/${getTag(false, version)}`
+  const response = await fetchRetry(tagURL, 'HEAD').catch(async (err) => {
     return await Promise.reject(new Error(`Can't get the tag: ${err}`))
   })
   return await Promise.resolve(response.url.replace(/tag/, 'download') + `/${piper}`)

diff --git a/test/fetch.test.ts b/test/fetch.test.ts
@@ -27,7 +27,7 @@ describe('Fetch package tests', () => {
       return mockResponse200
     })
 
-    await fetchRetry(testURL, tries, delay)
+    await fetchRetry(testURL, undefined, tries, delay)
     expect(core.info).toHaveBeenCalledTimes(0)
   })
 
@@ -39,7 +39,7 @@ describe('Fetch package tests', () => {
       return mockResponse200
     })
 
-    await fetchRetry(testURL, tries, delay)
+    await fetchRetry(testURL, undefined, tries, delay)
 
     expect(info).toHaveBeenCalledWith(`Error while fetching ${testURL}: Internal Server Error`)
     expect(info).toHaveBeenCalledWith('Retrying 2 more time(s)...')
@@ -51,7 +51,7 @@ describe('Fetch package tests', () => {
       return mockResponse500
     })
 
-    await expect(fetchRetry(testURL, tries, delay)).rejects.toThrow(`Error fetching ${testURL}`)
+    await expect(fetchRetry(testURL, undefined, tries, delay)).rejects.toThrow(`Error fetching ${testURL}`)
 
     expect(info).toHaveBeenCalledWith(`Error while fetching ${testURL}: Internal Server Error`)
     expect(info).toHaveBeenCalledWith('Retrying 2 more time(s)...')