-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce ADP FLP config generator #2730
Conversation
🦋 Changeset detectedLatest commit: 42e0938 The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall code the new package looks good
...ages/odata-service-inquirer/src/prompts/datasources/sap-system/system-selection/questions.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- changes to i18n package looks good
- review comments addressed
- good test coverage
- did not test locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New module @sap-ux/adp-flp-config-sub-generator setup looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just some minor comments.
packages/adp-flp-config-sub-generator/src/translations/adp-flp-config-sub-generator.i18n.json
Show resolved
Hide resolved
…ithub.com/SAP/open-ux-tools into feat/2727/adp-flp-configuration-generator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good
Changeset is good
Coverage is good
Did not test manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-approving, no changes for i18n related code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- code looks good
- great coverage
- tested manually - works as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-approving new module setup
|
* origin/main: (43 commits) chore: apply latest changesets feat(abap-deploy-config-inq): option for createDuringDeploy list item (#2864) chore: apply latest changesets feat(preview-middleware):add support for type component (#2872) chore: apply latest changesets feat: introduce ADP FLP config generator (#2730) fix(cf-gen): fix unstable windows test (#2876) chore: apply latest changesets fix: project access dependency (#2875) chore: apply latest changesets feat(odata-service-inquirer): #2866 - Adds cf bas prompts (#2867) chore: apply latest changesets feat: add context menu for outline in cpe (#2847) chore: apply latest changesets feat(cf-gen): adds new sub generator to `@sap-ux/cf-deploy-config-sub-generator` (#2844) chore: apply latest changesets fix: Default model naming (#2862) chore: apply latest changesets correct command type for add annotation file (#2839) chore: apply latest changesets ...
#2727
Introduce standalone FLP configuration generator for Adaptation Projects