Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce ADP FLP config generator #2730

Merged
merged 76 commits into from
Feb 5, 2025

Conversation

mmilko01
Copy link
Contributor

@mmilko01 mmilko01 commented Dec 20, 2024

#2727

Introduce standalone FLP configuration generator for Adaptation Projects

Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: 42e0938

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages
Name Type
@sap-ux/adp-flp-config-sub-generator Patch
@sap-ux/adp-tooling Patch
@sap-ux/i18n Patch
@sap-ux/create Patch
@sap-ux/flp-config-inquirer Patch
@sap-ux/preview-middleware Patch
@sap-ux/cf-deploy-config-sub-generator Patch
@sap-ux/fe-fpm-writer Patch
@sap-ux/flp-config-sub-generator Patch
@sap-ux/project-access Patch
@sap-ux/app-config-writer Patch
@sap-ux/abap-deploy-config-sub-generator Patch
@sap-ux/abap-deploy-config-writer Patch
@sap-ux/annotation-generator Patch
@sap-ux/cap-config-writer Patch
@sap-ux/cards-editor-middleware Patch
@sap-ux/cf-deploy-config-writer Patch
@sap-ux/environment-check Patch
@sap-ux/fiori-annotation-api Patch
@sap-ux/fiori-generator-shared Patch
@sap-ux/launch-config Patch
@sap-ux/odata-service-inquirer Patch
@sap-ux/odata-service-writer Patch
@sap-ux/project-integrity Patch
@sap-ux/telemetry Patch
@sap-ux/ui5-application-inquirer Patch
@sap-ux/ui5-library-reference-inquirer Patch
@sap-ux/ui5-library-reference-sub-generator Patch
@sap-ux/ui5-library-reference-writer Patch
@sap-ux/ui5-library-writer Patch
@sap-ux/fiori-elements-writer Patch
@sap-ux/fiori-freestyle-writer Patch
@sap-ux/fe-fpm-cli Patch
@sap-ux/abap-deploy-config-inquirer Patch
@sap-ux/deploy-config-generator-shared Patch
@sap-ux/inquirer-common Patch
@sap-ux/ui5-library-sub-generator Patch
@sap-ux/generator-simple-fe Patch
@sap-ux/cf-deploy-config-inquirer Patch
@sap-ux/ui5-library-inquirer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@nikmace nikmace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall code the new package looks good

@testojs testojs self-requested a review January 8, 2025 08:23
@mmilko01 mmilko01 added adp-tooling feature New feature or request labels Jan 8, 2025
@mmilko01 mmilko01 marked this pull request as ready for review January 8, 2025 12:26
@mmilko01 mmilko01 requested review from a team as code owners January 8, 2025 12:26
voicis
voicis previously approved these changes Feb 4, 2025
Copy link
Contributor

@voicis voicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • changes to i18n package looks good
  • review comments addressed
  • good test coverage
  • did not test locally

@nikmace nikmace self-requested a review February 4, 2025 10:39
devinea
devinea previously approved these changes Feb 4, 2025
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New module @sap-ux/adp-flp-config-sub-generator setup looks good.

Copy link
Contributor

@nikmace nikmace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just some minor comments.

@mmilko01 mmilko01 dismissed stale reviews from voicis and devinea via 1f81c49 February 5, 2025 08:14
@nikmace nikmace self-requested a review February 5, 2025 09:40
Copy link
Contributor

@nikmace nikmace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good
Changeset is good
Coverage is good
Did not test manually

Copy link
Contributor

@voicis voicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approving, no changes for i18n related code.

@mmilko01 mmilko01 requested a review from devinea February 5, 2025 11:15
Copy link
Contributor

@testojs testojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • code looks good
  • great coverage
  • tested manually - works as expected

Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approving new module setup

@mmilko01 mmilko01 merged commit 78bc772 into main Feb 5, 2025
16 checks passed
@mmilko01 mmilko01 deleted the feat/2727/adp-flp-configuration-generator branch February 5, 2025 16:44
devinea added a commit that referenced this pull request Feb 7, 2025
* origin/main: (43 commits)
  chore: apply latest changesets
  feat(abap-deploy-config-inq): option for createDuringDeploy list item (#2864)
  chore: apply latest changesets
  feat(preview-middleware):add support for type component (#2872)
  chore: apply latest changesets
  feat: introduce ADP FLP config generator (#2730)
  fix(cf-gen): fix unstable windows test (#2876)
  chore: apply latest changesets
  fix: project access dependency (#2875)
  chore: apply latest changesets
  feat(odata-service-inquirer): #2866 - Adds cf bas prompts (#2867)
  chore: apply latest changesets
  feat: add context menu for outline in cpe (#2847)
  chore: apply latest changesets
  feat(cf-gen): adds new sub generator to `@sap-ux/cf-deploy-config-sub-generator` (#2844)
  chore: apply latest changesets
  fix: Default model naming (#2862)
  chore: apply latest changesets
  correct command type for add annotation file (#2839)
  chore: apply latest changesets
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adp-tooling feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants