Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@sap-ux/odata-service-inquirer): Reset connection when selecting new system type #2729

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

IainSAP
Copy link
Contributor

@IainSAP IainSAP commented Dec 19, 2024

Fix for #2723

  • Reset connection on system type change
  • Return true to defer validation to later prompts (otherwise the user is blocked)

Copy link

changeset-bot bot commented Dec 19, 2024

🦋 Changeset detected

Latest commit: 24c10a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/odata-service-inquirer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@IainSAP IainSAP assigned IainSAP and unassigned IainSAP Dec 20, 2024
Copy link
Contributor

@cianmSAP cianmSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are clear
Tests to cover
Patch changeset ✅

Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes are clear and tested.
changeset ✅

@IainSAP IainSAP merged commit 2d4fc36 into main Dec 20, 2024
16 checks passed
@IainSAP IainSAP deleted the fix/2723/reset_connection_state_on_system_type_change branch December 20, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants