Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

708/return cf abap service name #2709

Merged
merged 8 commits into from
Dec 18, 2024
Merged

Conversation

longieirl
Copy link
Contributor

@longieirl longieirl commented Dec 16, 2024

Fix for #2708

  • add async and return correct label and service for the selected CF ABAP instance
  • only return the expected type of label:string and service:string rather than the entire service object which getCFAbapInstanceChoices returns by default.
  • add extra logging in cf-writer to make it easier to debug
  • cleanup logging which is not formatting the mtaPath correctly

Copy link

changeset-bot bot commented Dec 16, 2024

🦋 Changeset detected

Latest commit: 6197443

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sap-ux/cf-deploy-config-inquirer Patch
@sap-ux/cf-deploy-config-writer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@longieirl longieirl self-assigned this Dec 16, 2024
@longieirl longieirl marked this pull request as ready for review December 17, 2024 13:04
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are clear
changeset ✅

Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @longieirl

  • Tests added to cover
  • Not tested locally

@longieirl longieirl merged commit 2fab480 into main Dec 18, 2024
16 checks passed
@longieirl longieirl deleted the 708/return-cf-abap-service-name branch December 18, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants