Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-application-inquirer): Fix non-loaded i18n texts #2666

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

IainSAP
Copy link
Contributor

@IainSAP IainSAP commented Dec 5, 2024

Fix for: #2590

  • Loads bundles explicitly

@IainSAP IainSAP self-assigned this Dec 5, 2024
Copy link

changeset-bot bot commented Dec 5, 2024

🦋 Changeset detected

Latest commit: 8b3875f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/ui5-application-inquirer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@IainSAP IainSAP requested a review from longieirl December 5, 2024 15:11
@IainSAP IainSAP requested a review from cianmSAP December 5, 2024 15:14
@IainSAP IainSAP changed the title Fixes non-loaded i18n texts fix(ui5-application-inquirer): Fix non-loaded i18n texts Dec 5, 2024
Copy link
Contributor

@cianmSAP cianmSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good for known issue

Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
Comments addressed.

@IainSAP IainSAP merged commit b67b17d into main Dec 5, 2024
16 checks passed
@IainSAP IainSAP deleted the fix/2590/non_loading_texts_ui5_app_inq branch December 5, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants