Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(odata-service-inquirer): i18n bundles not loading #2592

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

IainSAP
Copy link
Contributor

@IainSAP IainSAP commented Nov 19, 2024

Fix for : #2590

Copy link

changeset-bot bot commented Nov 19, 2024

🦋 Changeset detected

Latest commit: fa42b8c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/odata-service-inquirer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@IainSAP IainSAP self-assigned this Nov 19, 2024
@IainSAP IainSAP changed the title Fix for i18n bundles not loading fix(odata-service-inquirer): 18n bundles not loading Nov 19, 2024
@IainSAP IainSAP changed the title fix(odata-service-inquirer): 18n bundles not loading fix(odata-service-inquirer): i18n bundles not loading Nov 19, 2024
Copy link
Contributor

@cianmSAP cianmSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good
Existing TBI to investigate this issue #2498

Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@IainSAP IainSAP merged commit 481e6b4 into main Nov 19, 2024
13 checks passed
@IainSAP IainSAP deleted the fix/2590/i18n_not_loading branch November 19, 2024 10:30
devinea added a commit that referenced this pull request Nov 19, 2024
* origin/main:
  chore - Fix audit issues (#2528)
  chore: apply latest changesets
  fix(fiori-gen-shared): fix reading README template in fiori gen shared (#2595)
  chore: apply latest changesets
  fix(odata-service-inquirer): i18n bundles not loading (#2592)
  chore: apply latest changesets
  feat(btp-utils): adds options for list destination api (#2586)
  chore: apply latest changesets
  fix(abap-deploy-config-writer): add `reentranceTicket` auth type to all deploy configs when passed in (#2556)
devinea added a commit that referenced this pull request Nov 19, 2024
* origin/main:
  chore - Fix audit issues (#2528)
  chore: apply latest changesets
  fix(fiori-gen-shared): fix reading README template in fiori gen shared (#2595)
  chore: apply latest changesets
  fix(odata-service-inquirer): i18n bundles not loading (#2592)
  chore: apply latest changesets
  feat(btp-utils): adds options for list destination api (#2586)
  chore: apply latest changesets
  fix(abap-deploy-config-writer): add `reentranceTicket` auth type to all deploy configs when passed in (#2556)
  chore: apply latest changesets
  feat: add namespaces to annotation template (#2452)
  chore: apply latest changesets
  fix: Handle higher layer changes (#2536)
  chore: apply latest changesets
  fix(cf-deploy-config-writer): cleanup based on local testing when using headless (#2546)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants