Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - the CF ABAP instances list is not returning the correct service and label #2708

Open
3 tasks
longieirl opened this issue Dec 16, 2024 · 0 comments
Open
3 tasks
Assignees
Labels
bug Something isn't working cf-deploy-config-inquirer

Comments

@longieirl
Copy link
Contributor

Related Feature

Feature request: issue number

Description

The following cf-inquireranswers object is missing the serviceName when the CF ABAP choices are returned;

function getServiceProvider(): CfAppRouterDeployConfigQuestions {

Response;

 {
  "inputDestinationRoot": "/Users/I313149/Documents/tools-suite/packages/deployment-generator",
  "prefix": "testme2",
  "mtaDescription": "",
  "mtaVersion": "0.0.1",
  "routerType": "standard",
  "addConnectivityService": true,
  "useABAPServiceBinding": true,
  "selectedABAPService": {
    "label": "abap-05"
  }
}

The selectedABAPService is not returning the service as defined by the type;

    abapServiceProvider?: {
        label?: string;
        service?: String;
    };

Steps to Reproduce

Steps to reproduce the behavior:

  1. Load CF Approuter Configuration
  2. Select Standalone as router type
  3. Configured advanced options Yes
  4. Select ABAP Env for direct service binding

Expected results

Select the service and generate standalone approuter project

Actual results

cf-writing phase is failing since the serviceName is not being passed.

Screenshots

If applicable, add screenshots to help explain the problem.

Version/Components/Environment

Add any other context about the problem here
OS:

  • Mac OS
  • Windows
  • Other

Root Cause Analysis

Problem

{describe the problem}

Fix

{describe the fix}

Why was it missed

{Some explanation why this issue might have been missed during normal development/testing cycle}

How can we avoid this

{if we don’t want to see this type of issues anymore what we should do to prevent}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cf-deploy-config-inquirer
Projects
None yet
Development

No branches or pull requests

1 participant