Skip to content

Commit

Permalink
chore - Update actions - fix broken pipeline (#2118)
Browse files Browse the repository at this point in the history
* Chore - actions update

* Skip int test for older windows versions
  • Loading branch information
devinea authored Jul 4, 2024
1 parent ede39a4 commit 0015592
Show file tree
Hide file tree
Showing 5 changed files with 32 additions and 29 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v3
uses: actions/checkout@v4

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@ jobs:

steps:
- name: Checkout code repository
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.ref }}
- name: Setup pnpm
uses: pnpm/action-setup@v2.4.0
uses: pnpm/action-setup@v4
with:
run_install: true
- name: Cache pnpm modules
uses: actions/cache@v3
uses: actions/cache@v4
env:
cache-name: cache-pnpm-modules
with:
Expand All @@ -37,7 +37,7 @@ jobs:
restore-keys: |
${{ matrix.os }}-build-${{ env.cache-name }}-${{ matrix.node-version }}-
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: Install pnpm modules
Expand Down
28 changes: 14 additions & 14 deletions .github/workflows/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@ jobs:
timeout-minutes: 15
steps:
- name: Checkout code repository
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Setup pnpm
uses: pnpm/action-setup@v2.4.0
uses: pnpm/action-setup@v4
with:
run_install: true
- name: Cache pnpm modules
uses: actions/cache@v3
uses: actions/cache@v4
env:
cache-name: cache-pnpm-modules
with:
Expand All @@ -33,7 +33,7 @@ jobs:
restore-keys: |
${{ matrix.os }}-build-${{ env.cache-name }}-${{ matrix.node-version }}-
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: Install pnpm modules
Expand All @@ -44,7 +44,7 @@ jobs:
run: pnpm run test
- name: Cache playwright browsers
id: cache-playwright-browsers
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: |
${{ runner.os == 'Windows' }}:
Expand Down Expand Up @@ -81,16 +81,16 @@ jobs:
changes: ${{ steps.changesetVersion.outputs.changes }} # map step output to job output
steps:
- name: Checkout code repository
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0
token: ${{ secrets.ACCESS_PAT }}
- name: Setup pnpm
uses: pnpm/action-setup@v2.4.0
uses: pnpm/action-setup@v4
with:
run_install: true
- name: Cache pnpm modules
uses: actions/cache@v3
uses: actions/cache@v4
env:
cache-name: cache-pnpm-modules
with:
Expand All @@ -99,7 +99,7 @@ jobs:
restore-keys: |
${{ runner.os }}-build-${{ env.cache-name }}-
- name: Use Node.js 18.x
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 18.x
- name: Install pnpm modules
Expand Down Expand Up @@ -129,13 +129,13 @@ jobs:
needs: version
steps:
- name: Checkout code repository
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Setup pnpm
uses: pnpm/action-setup@v2.4.0
uses: pnpm/action-setup@v4
with:
run_install: true
- name: Cache pnpm modules
uses: actions/cache@v3
uses: actions/cache@v4
env:
cache-name: cache-pnpm-modules
with:
Expand All @@ -144,7 +144,7 @@ jobs:
restore-keys: |
${{ runner.os }}-build-${{ env.cache-name }}-
- name: Use Node.js 18.x
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 18.x
- name: Install pnpm modules
Expand All @@ -171,7 +171,7 @@ jobs:
echo "$EOF" >> $GITHUB_ENV
- name: Send Slack notification
if: steps.changesetPublish.outputs.published == 'true'
uses: slackapi/slack-github-action@v1.24.0
uses: slackapi/slack-github-action@v1.26.0
with:
payload: |
{"text": ":rocket: The following packages were published to npmjs.com:\n${{ env.PUBLISHED_PACKAGES_MESSAGE }}" }
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/reuse-compliance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ jobs:
reuse-lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: REUSE Compliance Check
uses: fsfe/reuse-action@v1
uses: fsfe/reuse-action@v4
Original file line number Diff line number Diff line change
Expand Up @@ -116,13 +116,16 @@ const check = async (param: { page: Page }) => {
const UI5Versions = JSON.parse(process.env.UI5Versions ?? '[]') as UI5Version[];

for (const { version } of UI5Versions) {
test.describe(`UI5 version: ${version}`, () => {
test.afterEach(async () => {
await teardownServer();
// Skip for older versions as bootstrap does not work
if (!['1.96.33', '1.84.48', '1.71.69', '1.38.62'].includes(version)) {
test.describe(`UI5 version: ${version}`, () => {
test.afterEach(async () => {
await teardownServer();
});
test('Click on Go button and check an element ', async ({ page }) => {
await prepare(version);
await check({ page });
});
});
test('Click on Go button and check an element ', async ({ page }) => {
await prepare(version);
await check({ page });
});
});
}
}

0 comments on commit 0015592

Please sign in to comment.