Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: caching data verticle filter fix #596

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VladimirsKuzmins
Copy link

Previously, the CachingDataVerticle would not call FilterDataFromCache if the data was already cached in cacheRegister, as the future would succeed directly, bypassing FilterDataFromCache inside the retrieveData method. The fix involves attaching the FilterDataFromCache composition to the outer future instead of the inner future that handles locking. This ensures that FilterDataFromCache is executed in all cases, whether the data is fetched from cacheRegister or retrieved via cache or retrieveDataToCache.

@VladimirsKuzmins VladimirsKuzmins requested a review from a team as a code owner January 29, 2025 10:23
Copy link

cla-assistant bot commented Jan 29, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant