bug: caching data verticle filter fix #596
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
CachingDataVerticle
would not callFilterDataFromCache
if the data was already cached incacheRegister
, as the future would succeed directly, bypassingFilterDataFromCache
inside theretrieveData
method. The fix involves attaching theFilterDataFromCache
composition to the outer future instead of the inner future that handles locking. This ensures thatFilterDataFromCache
is executed in all cases, whether the data is fetched fromcacheRegister
or retrieved viacache
orretrieveDataToCache
.