Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #565 batch requests issue #587

Merged
merged 6 commits into from
Dec 5, 2024
Merged

fix: #565 batch requests issue #587

merged 6 commits into from
Dec 5, 2024

Conversation

ikalachy
Copy link
Contributor

@ikalachy ikalachy commented Nov 20, 2024 •
edited by carlspring
Loading

Fixes #565 .

@ikalachy ikalachy self-assigned this Nov 20, 2024
@ikalachy ikalachy marked this pull request as ready for review December 3, 2024 12:12
@ikalachy ikalachy requested a review from a team as a code owner December 3, 2024 12:12
halber
halber reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@halber halber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but is it possible to provide a unit test?

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ikalachy ikalachy requested a review from halber December 4, 2024 17:31
carlspring
carlspring approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@carlspring carlspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

halber
halber approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@halber halber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ikalachy ikalachy merged commit 9dee408 into SAP:main Dec 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halber halber halber approved these changes

@carlspring carlspring carlspring approved these changes

Assignees

@ikalachy ikalachy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: $batch requests fails
3 participants
@ikalachy @carlspring @halber