Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): address Avatar Group issues #12530

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

khotcholava
Copy link
Contributor

fix(core): Resolve focus retention & rendering issues, add feature enhancements

Closes #12369

Description

  • Fixed focus bug where focus remained on the first avatar group control after interacting with the second one.
  • Fixed rendering issue where only "+n more" button displayed after switching tabs instead of the full avatar group row.
  • Added feature to open group popover from the center of the avatar group.
  • Added configuration option to make "+n more" button circular to match avatars typically being in circle shapes.
  • Introduced property to set the number of visible avatars before displaying the "+n more" button.

khotcholava and others added 5 commits September 25, 2024 17:55
closes (#12369)[#12369]

## Description
- Implemented avatar details placement feature
- Implemented avatar overflow button circle state
closes (#12369)[#12369]

## Description
- Add maxVisibleItems input to limit the number of visible avatars in AvatarGroupHostComponent, retaining default behavior when unset
- Fixed focus on avatar group
…hancements

Closes [#12369](#12369)

## Description
- Fixed focus bug where focus remained on the first avatar group control after interacting with the second one.
- Fixed rendering issue where only "+n more" button displayed after switching tabs instead of the full avatar group row.
- Added feature to open group popover from the center of the avatar group.
- Added configuration option to make "+n more" button circular to match avatars typically being in circle shapes.
- Introduced property to set the number of visible avatars before displaying the "+n more" button.
@khotcholava khotcholava self-assigned this Oct 10, 2024
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit f587f50
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/670e2e282e582c000890d134
😎 Deploy Preview https://deploy-preview-12530--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Oct 10, 2024

Visit the preview URL for this PR (updated for commit f587f50):

https://fundamental-ngx-gh--pr12530-fix-core-avatar-gro-krwggyds.web.app

(expires Fri, 18 Oct 2024 09:00:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

@InnaAtanasova InnaAtanasova changed the title Fix(core) avatar group bugs fix(core): address Avatar Group issues Oct 11, 2024
@InnaAtanasova InnaAtanasova requested a review from a team October 11, 2024 14:55
@InnaAtanasova InnaAtanasova added the bug Something isn't working label Oct 11, 2024
<fd-avatar-group-default-example></fd-avatar-group-default-example>
</component-example>
<code-example [exampleFiles]="avatarGroupDefaultExample"></code-example>
<!--<fd-docs-section-title id="default" componentName="AvatarGroup"> Avatar Group Standard Usage </fd-docs-section-title>-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental commit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's not ready yet for review. I converted this PR as a draft. @mikerodonnell89

@khotcholava khotcholava marked this pull request as draft October 14, 2024 16:15
Copy link
Member

@mikerodonnell89 mikerodonnell89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but what is going on with all of the commented out html?

closes [#12369](#12369)

- Fixed avatar overflow body focus issue
@khotcholava khotcholava marked this pull request as ready for review October 15, 2024 08:58
@droshev droshev requested a review from a team October 15, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] fd-avatar-group focus, overflow bugs
3 participants