fix(platform): Combine Sorting, Filtering, and Grouping Settings into a Single Dialog #12502
Mergeable / Mergeable
failed
Oct 14, 2024 in 3s
1/3 Fail(s): APPROVALS
Status: FAIL
Here are some stats of the run:
3 validations were ran.
2 PASSED
1 FAILED
Details
✔️ Validator: TITLE
- ✔️ title must exclude '^[WIP]'
Input : fix(platform): Combine Sorting, Filtering, and Grouping Settings into a Single Dialog
Settings :{"must_exclude":{"regex":"^\\[WIP\\]","message":"This is work in progress. Do not merge yet."}}
- ✔️ title must include '^(feat|docs|chore|fix|test)((\w+))?(:|().+$'
Input : fix(platform): Combine Sorting, Filtering, and Grouping Settings into a Single Dialog
Settings :{"must_include":{"regex":"^(feat|docs|chore|fix|test)(\\(\\w+\\))?(:|\\().+$","message":"Semantic release conventions must be followed."}}
✔️ Validator: DESCRIPTION
- ✔️ description must exclude '[ ]'
Input : ## Related Issue(s)
Description
This PR refactors the TableViewSettingsDialogComponent to combine sorting, filtering, and grouping functionality into a single dialog. Previously, sorting, filtering, and grouping were handled by separate dialogs, but now they are merged for a more streamlined user experience. This also reduces code duplication and improves maintainability.
Key changes:
- Created a combined settings dialog for table view settings.
- Refactored the sorting, filtering, and grouping functionalities using Angular signals for optimized state management.
- Added support for sorting, filtering, and grouping in one interface.
- Removed the logic from the individual sorting, filtering, and grouping dialogs and merged it into one component.
- Updated tests to reflect the new combined dialog structure.
- Adjusted documentation and examples to reflect the new functionality.
Screenshots
Before:
After:
Screen.Recording.2024-10-03.at.15.18.55.mov
Settings : ```{"must_exclude":{"regex":"\\[ \\]","message":"There are incomplete TODO task(s) unchecked."}}```
❌ Validator: APPROVALS
- ❌ (approvals: InnaAtanasova required OR approvals: droshev required OR approvals: dpavlenishvili required OR approvals: mikerodonnell89 required OR approvals count is less than "2")
Input :
Settings :{"or":[{"required":{"reviewers":["InnaAtanasova"]}},{"required":{"reviewers":["droshev"]}},{"required":{"reviewers":["dpavlenishvili"]}},{"required":{"reviewers":["mikerodonnell89"]}},{"min":{"count":2}}]}
Loading