generated from SAP/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Operator: Service type implemented #179
Open
Pavan-SAP
wants to merge
12
commits into
main
Choose a base branch
from
serviceType
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for tenant independent "service" workload(s), that may be exposed under an own subdomain.
Checks implemented - 1. Allow `Service` type 2. Don't allow TenantOperation/CustomTenantOperation if all the workloads are of type `Service` 3. Check if the workload name is valid in the ServiceExposure. It should be of type `Service`
Amongst other things, this is used to prevent some tenant related handling.
Ensure only the releavant DNS entries are removed when cleaning up DNS entries for a service.
Service <--> Tenant switch error handling enhanced. There is now a message on LatestReady condition until the issue is resolved.
workload name duplicate check code updated
Add tests to improve overall coverage for Service workloads.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO