Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: context menus based on project type #132

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Conversation

bd82
Copy link
Member

@bd82 bd82 commented Oct 19, 2021

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Oct 19, 2021

This pull request introduces 1 alert when merging 43312e2 into fbbf234 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Oct 20, 2021

This pull request introduces 2 alerts when merging 23c3667 into fbbf234 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Oct 20, 2021

This pull request introduces 3 alerts when merging 22e5efc into fbbf234 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Oct 21, 2021

This pull request introduces 3 alerts when merging e4fdd2e into fbbf234 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Oct 21, 2021

This pull request introduces 3 alerts when merging 7362c9d into fbbf234 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@bd82 bd82 force-pushed the context-menu-proj-type branch 2 times, most recently from 7709f49 to 87a54bb Compare November 30, 2021 12:36
@lgtm-com
Copy link

lgtm-com bot commented Nov 30, 2021

This pull request introduces 1 alert when merging e0694df into 8f3e6b4 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

.vscode/launch.json Outdated Show resolved Hide resolved
nyc.config.js Outdated Show resolved Hide resolved
@@ -60,6 +63,7 @@
"shx": "^0.3.3",
"rimraf": "^3.0.2",
"patch-package": "6.4.7",
"ts-node": "^10.4.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ts-node does not always work well with monorepos + typescript

@@ -25,6 +31,26 @@ export function activate(context: ExtensionContext): BasToolkit {
const basToolkitAPI = createBasToolkitAPI(workspaceAPI, baseBasToolkitAPI);

const logger = getLogger().getChildLogger({ label: "activate" });
// using `.then` instead of `await` to keep the activate function synchronized
// to avoid automatic wrapping of `BasToolKit` API in a promise.
workspaceAPI
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may want to extract the initial setup of the tags to a utility function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants