Deploy on BTP #793
Draft
Deploy on BTP #793
+6,712
−3,198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oyment config files
Closed
Akatuoro
reviewed
Jan 27, 2025
orders/package.json
Outdated
Comment on lines
12
to
16
| "[production]": { | ||
| "auth": "xsuaa", | ||
| "db": "hana", | ||
| "messaging": "enterprise-messaging" | ||
| } |
There was a problem hiding this comment.
Need to test if this really is necessary - these configurations should already be the default for production
There was a problem hiding this comment.
"messaging": "enterprise-messaging" still needed
| @@ -0,0 +1,139 @@ | |||
| { | |||
There was a problem hiding this comment.
Need to test if this is already generated during build if not present - if not, would be good to improve the tooling
vl-leon
force-pushed
the
deploy-on-btp
branch
from
d6c5c62 to
ff9224f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minimal changes required to deploy bookshop in sharedDB mode: