Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CAP Java 3.0 ... #344

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Use CAP Java 3.0 ... #344

merged 3 commits into from
Jul 17, 2024

Conversation

mofterdinger
Copy link
Member

and:

@mofterdinger
Use CAP Java 3.0 ...
a623e25 
and:
- @sap/[email protected]
- spring-boot 3.3.1
@vmikhailenko

This comment was marked as off-topic.

Sign in to view
@vmikhailenko
Copy link
Contributor

vmikhailenko commented Jul 17, 2024 •
edited
Loading

package.json on top still references @sap/cds-dk as 7.

Revert #338?

@mofterdinger
Copy link
Member Author

package.json on top still references @sap/cds-dk as 7.

Revert #338?

Fixed in package.json, thanks for this hint.

@mofterdinger
Copy link
Member Author

Sidecar needs to be updated as well.

There is no sidecar in PG branch.

@mofterdinger mofterdinger enabled auto-merge (squash) July 17, 2024 09:09
beckermarc
beckermarc requested changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@beckermarc beckermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also cleanup the cds build command in srv/pom.xml and remove the opts that are no longer required

@mofterdinger mofterdinger merged commit ec3774a into postgres Jul 17, 2024
2 checks passed
@mofterdinger mofterdinger deleted the pg_version_bump branch July 17, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckermarc beckermarc beckermarc approved these changes

@vmikhailenko vmikhailenko Awaiting requested review from vmikhailenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mofterdinger @vmikhailenko @beckermarc