Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreSQL: Demonstrate integration-tests module with Testcontainers #268

Closed
wants to merge 5 commits into from

Conversation

mofterdinger
Copy link
Member

@mofterdinger mofterdinger commented Nov 16, 2023

This PR demonstrates how we can leverage Testcontainers in a integration-tests module and using the failsafe-plugin to execute the tests. This PR is just proposal how it could look like.

@mofterdinger mofterdinger changed the title add integration-tests module PostgreSQL: Demonstrate integration-tests module with Testcontainers Nov 16, 2023
@mofterdinger mofterdinger marked this pull request as draft November 16, 2023 13:21
@vmikhailenko
Copy link
Contributor

I am fine with this in a didactic sense. But the existing test already uses the Postgres in a test container...

@mofterdinger
Copy link
Member Author

I am fine with this in a didactic sense. But the existing test already uses the Postgres in a test container...

Yes, I know we show already the Testcontainers setup. The configuration in a separate integration-tests module is different, maybe we just keep it in an additional branch.

@beckermarc
Copy link
Contributor

maybe we just keep it in an additional branch.

Please don't introduce even more branches, that need to be kept up-to-date :)

@mofterdinger
Copy link
Member Author

ok, pushed it into our internal repo. I'm using this kind of setup in another project and I just wanted to share.

@mofterdinger mofterdinger deleted the postgres_itests branch November 16, 2023 15:23
@beckermarc
Copy link
Contributor

I wasn't arguing against merging this branch! I just wanted to make sure that we do not add more branches, but why not merge this, if it is useful?

@mofterdinger
Copy link
Member Author

I wasn't arguing against merging this branch! I just wanted to make sure that we do not add more branches, but why not merge this, if it is useful?

yes, I know, not sure if this setup is relevant for stakeholders, I just wanted to show it with the bookshop pg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants