Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup .cdsrc.json #263

Merged
merged 4 commits into from
Oct 30, 2023
Merged

cleanup .cdsrc.json #263

merged 4 commits into from
Oct 30, 2023

Conversation

mofterdinger
Copy link
Member

@mofterdinger mofterdinger commented Oct 30, 2023

See: #262

@beckermarc
Copy link
Contributor

According to my understanding the file could even be a completely empty JSON object or even removed, as also profile java is auto-configured.

@mofterdinger
Copy link
Member Author

According to my understanding the file could even be a completely empty JSON object or even removed, as also profile java is auto-configured.

ok, I will try without .cdsrc.json.

@mofterdinger
Copy link
Member Author

mofterdinger commented Oct 30, 2023

cool, it works without a .cdsrc.json, the cds build works fine and bookshop starts.

@beckermarc
Copy link
Contributor

Don't we use .cdsrc.json also as an indicator in our Maven Plugin for the root of the project?
Maybe better keep an empty file? If we remove it, we should I think avoid putting config into package.json but rather readd .cdsrc.json if we need it.

@mofterdinger
Copy link
Member Author

mofterdinger commented Oct 30, 2023

The cds-maven-plugin uses beside the .cdsrc.json also the package.json to find the build root. So, this is not a problem, the maven build works fine without a .cdsrc.json:

[INFO] CdsMojo: Using /Users/d032842/SAPDevelop/.m2/repository/com/sap/cds/cds-maven-plugin/cache/unpacked/18.18.2/unpacked-18.18.2-darwin-x64.tar.gz/node-v18.18.2-darwin-x64/bin/npx provided by goal install-node.
[INFO] CdsMojo: Using directory containing a package.json as working directory: /Users/d032842/SAPDevelop/git/cloud-cap-samples-java
[INFO] CdsMojo: Executing [/Users/d032842/SAPDevelop/.m2/repository/com/sap/cds/cds-maven-plugin/cache/unpacked/18.18.2/unpacked-18.18.2-darwin-x64.tar.gz/node-v18.18.2-darwin-x64/bin/npx, -c, cds version] in working directory /Users/d032842/SAPDevelop/git/cloud-cap-samples-java
[INFO] CdsMojo: Using configured working directory: /Users/d032842/SAPDevelop/git/cloud-cap-samples-java
[INFO] CdsMojo: Executing [/Users/d032842/SAPDevelop/.m2/repository/com/sap/cds/cds-maven-plugin/cache/unpacked/18.18.2/unpacked-18.18.2-darwin-x64.tar.gz/node-v18.18.2-darwin-x64/bin/npx, -c, cds build --for java] in working directory /Users/d032842/SAPDevelop/git/cloud-cap-samples-java
[INFO] CdsMojo: [cds] - building project [/Users/d032842/SAPDevelop/git/cloud-cap-samples-java], clean [true]
[cds] - cds-dk [7.3.0], cds [7.3.0], compiler [4.3.0], home [/Users/d032842/SAPDevelop/git/cloud-cap-samples-java/node_modules/@sap/cds]

[INFO] CdsMojo: Using directory containing a package.json as working directory: /Users/d032842/SAPDevelop/git/cloud-cap-samples-java

But yes, we can keep an empty .cdsrc.json, to avoid future CDS configurations in package.json.

@mofterdinger mofterdinger merged commit 6564076 into postgres Oct 30, 2023
2 checks passed
@mofterdinger mofterdinger deleted the postgres_cleanup branch October 30, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants