Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct extension by removing full stop #8

Merged
merged 3 commits into from
Mar 30, 2023

Conversation

mattieharding
Copy link
Contributor

At least in 1.71 this fullstop is not required - Assume it hasn't changed

At least in 1.71 this fullstop is not required - Assume it hasn't changed
@cla-assistant
Copy link

cla-assistant bot commented Oct 28, 2022

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Oct 28, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@KvM2
Copy link
Contributor

KvM2 commented Oct 28, 2022

Hello , thanks for your contribution! We really appreciate it and will look into this .

@JannaLisa
Copy link
Contributor

Hello @mattieharding ,
we're currently compiling a list of all the topics where this occurs and double-checking with development.
Please bear with us, this may take some time. But we'll try to make the change with 1.109.
We will post an update here!

@didzvein
Copy link

Hello @mattieharding,
We looked into this and indeed found a topic where it should be corrected. It's been updated and will appear in 1.109.
Thanks for your contribution!

@JannaLisa JannaLisa merged commit 70a2faa into SAP-docs:main Mar 30, 2023
@sap-doc-bot sap-doc-bot bot added the contribution Valuable Contribution label Mar 30, 2023
@sap-doc-bot
Copy link

sap-doc-bot bot commented Mar 30, 2023

Thank you for your valuable content contribution, @mattieharding! So that we can recognize your contribution in SAP Community, please tell us your SAP Community profile URL in a reply to this comment; don't include any other text, just the URL on its own, like this:

https://people.sap.com/your-user-name

Thanks!

@mattieharding
Copy link
Contributor Author

mattieharding commented Mar 30, 2023 via email

@qmacro qmacro added the mission-award SAP Community mission award label Apr 5, 2023
@OlMue OlMue added the type/examples-samples Related to existing examples/samples, or request for new examples/samples. label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Valuable Contribution mission-award SAP Community mission award SAP Fiori elements type/examples-samples Related to existing examples/samples, or request for new examples/samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants