Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all reference to custom folder with ext in the FE v4 documentation #7

Merged
merged 3 commits into from
Jul 4, 2023

Conversation

nlunets
Copy link
Contributor

@nlunets nlunets commented Oct 25, 2022

We've noticed that all samples in the V4 world were using custom as folder name while the guidelines should be ext
This PR fixes that

@cla-assistant
Copy link

cla-assistant bot commented Oct 25, 2022

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Oct 25, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@KvM2
Copy link
Contributor

KvM2 commented Oct 25, 2022

Hello , thanks for your contribution! We really appreciate your contribution and will look into this .

@JannaLisa
Copy link
Contributor

Hi @nlunets ,
Sorry for not having done this yet, and also for not responding for such a long time :-(
Will discuss with the team whether someone can take this up asap.

@mishuagrawal
Copy link
Contributor

Hello,

Please accept our sincere apologies for the delay in updating this request and the documentation. We have now fixed all the mentioned files. The changes should start reflecting post the next release.

I will be closing this request now. In case you have any further questions or concerns, please feel free to write back.

Thanks and regards,
Mishu Agrawal

@mishuagrawal mishuagrawal merged commit 5eae50e into SAP-docs:main Jul 4, 2023
@sap-doc-bot sap-doc-bot bot added the contribution Valuable Contribution label Jul 4, 2023
@OlMue OlMue added the type/examples-samples Related to existing examples/samples, or request for new examples/samples. label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Valuable Contribution follow-up-with/dev Clarification with development needed. SAP Fiori elements type/examples-samples Related to existing examples/samples, or request for new examples/samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants